-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 changelog: mention no breaking changes #1598
Conversation
Hi @aviau sorry that this is a miss from our side. Thanks. |
@peterzhuamazon done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@aviau you need to sign off DCO. |
Signed-off-by: aviau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should remove this section, its important to call out that we did not introduce any breaking changes.
Could you help me understand how when you saw the release notes it looked like there were many breaking changes, maybe a screenshot?
I won't put any more efforts here for something so pedantic, I think my issue description is self-explainatory. Empty sections aren't obvious in rendered markdown. If you don't agree then please just close my PR. |
I think it should either say None or be removed. Don’t care either way. @aviau thank you! @peternied ok merging as is or do you want to PR an alternative? |
Signed-off-by: aviau <[email protected]>
I know this is a past release but some of us are still migrating from ES and a big BREAKING CHANGES with title 10 thousand things under it is scary until you realize its an empty section. 🙃