Fixed an error in DeleleMlModel runner. #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Model and DeployMlModel. Signed-off-by: Vesa Pehkonen <[email protected]>
- added expection handling and logging for DeletePipeline runner - removed empty expection from DeleteMlModel and RegisterMlModel runners - added the "number-of-hits-to-return" variable Signed-off-by: Vesa Pehkonen <[email protected]>
Signed-off-by: Vesa Pehkonen <[email protected]>
…have to wait for undeploying the model process has completed. Signed-off-by: Vesa Pehkonen <[email protected]>
vpehkone
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
Signed-off-by: Vesa Pehkonen <[email protected]>
Signed-off-by: Vesa Pehkonen <[email protected]>
VijayanB
reviewed
May 24, 2024
VijayanB
reviewed
May 24, 2024
|
@vpehkone Can you create a github issue as bug and link this PR? Thanks |
Signed-off-by: Vesa Pehkonen <[email protected]>
IanHoang
reviewed
May 24, 2024
Signed-off-by: Vesa Pehkonen <[email protected]>
gkamat
reviewed
Jun 12, 2024
finnroblin
pushed a commit
to finnroblin/opensearch-benchmark
that referenced
this pull request
Jul 19, 2024
Signed-off-by: Vesa Pehkonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an error in DeleleMlModel runner.
Issues Resolved
The deleting model can fail, if the undeploying model has not yet completed. Added a loop for polling it.
Issue: #541
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.