Add vector search param source #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #424 |
VijayanB
force-pushed
the
add-params-source
branch
2 times, most recently
from
2acd13f to
b9e453e
Compare
|
Tested this PR with 1m-128d-l2-hdf5 vector dataset |
VijayanB
force-pushed
the
add-params-source
branch
4 times, most recently
from
84a9651 to
61a71bd
Compare
jmazanec15
reviewed
Dec 21, 2023
VijayanB
force-pushed
the
add-params-source
branch
from
61a71bd to
42b7155
Compare
VijayanB
force-pushed
the
add-params-source
branch
from
42b7155 to
9c9197d
Compare
navneet1v
approved these changes
Dec 21, 2023
VijayanB
force-pushed
the
add-params-source
branch
from
9c9197d to
cd361b8
Compare
jmazanec15
approved these changes
Dec 21, 2023
IanHoang
reviewed
Dec 22, 2023
osbenchmark/workload/params.py
Outdated
| return self.delegate_param_source.partition(partition_index, total_partitions) | ||
|
|
||
| def params(self): | ||
| raise exceptions.BenchmarkError("Do not use a VectorSearchParamSource without partitioning") |
There was a problem hiding this comment.
Might be more appropriate to use exceptions.WorkloadConfigError as apposed to catch-all exception exceptions.BenchmarkError
IanHoang
approved these changes
Dec 22, 2023
Added new param source to partition vector dataset and neighbors. This will be passed to runner to perform search and compare response with neighbors for recall calculation. This param source extends Search ParamSource to inherit search's other query parameters. Vector Param Source will add additional paramter that are required for vector serach operation type. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-params-source
branch
from
cd361b8 to
6d09dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new param source to partition vector dataset and
neighbors. This will be passed to runner to perform
search and compare response with neighbors for recall
calculation.
This param source extends Search ParamSource to inherit search's
other query parameters.
Vector Param Source will add additional paramter that are required
for vector serach operation type.
Issues Resolved
Part of #103
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.