Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async search editorial #807

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

Naarcha-AWS
Copy link
Contributor

Adds comments from #781

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

Changes Analysis

Commit SHA: bf864b1
Comparing To SHA: 592336a

API Changes

Summary

└─┬Paths
  ├─┬/_opendistro/_asynchronous_search
  │ └─┬POST
  │   ├─┬Parameters
  │   │ └──[🔀] description (15990:20)
  │   ├─┬Parameters
  │   │ └──[🔀] description (15999:20)
  │   └─┬Parameters
  │     └──[🔀] description (16005:20)
  ├─┬/_plugins/_asynchronous_search/stats
  │ └─┬GET
  │   └──[🔀] description (3707:20)
  ├─┬/_plugins/_asynchronous_search
  │ └─┬POST
  │   ├─┬Parameters
  │   │ └──[🔀] description (15999:20)
  │   ├─┬Parameters
  │   │ └──[🔀] description (16005:20)
  │   └─┬Parameters
  │     └──[🔀] description (15990:20)
  └─┬/_opendistro/_asynchronous_search/stats
    └─┬GET
      └──[🔀] description (13510:20)

Document Element Total Changes Breaking Changes
paths 8 0
  • Total Changes: 8
  • Modifications: 8

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12952545342/artifacts/2481532722

API Coverage

Before After Δ
Covered (%) 662 (64.84 %) 662 (64.84 %) 0 (0 %)
Uncovered (%) 359 (35.16 %) 359 (35.16 %) 0 (0 %)
Unknown 45 45 0

Copy link
Contributor

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Moving forward, please ensure that any added/modified text is submitted for editorial review prior to merging. Thanks!

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
594 593 (99.83 %)

@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jan 25, 2025
@dblock dblock merged commit 9df46f8 into opensearch-project:main Jan 25, 2025
29 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants