Fix: merging coverage includes plugin tests. #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
fix-coverage-pct
branch
from
095a4b2 to
5aeb5da
Compare
Changes AnalysisCommit SHA: 6902eaa API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11785290598/artifacts/2173027532 API Coverage
|
Spec Test Coverage Analysis
|
Signed-off-by: dblock <[email protected]>
Xtansia
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used
coverage/test-spec-coverage-${{ matrix.entry.version }}-${{ matrix.entry.tests || 'default' }}.jsonto make the coverage output file name, which may have contained/in cases likeplugins/index-management. This caused the coverage merge code not to pickup those files because it's looking fortest-spec-coverage-*.This fixes that by using the hash instead of the path name. The version still needs to be there to make it unique.
The result as expected is slightly better than in previous PRs (e.g. here vs. #661).
We also display paths that don't have tests when merging results so it's easier to identify tests to fill out.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.