Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding job scheduler dependency in bwc tests #1158

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Adding job scheduler dependency in bwc tests #1158

merged 5 commits into from
Jan 31, 2025
+25 −0

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Jan 31, 2025 •
edited
Loading

Description

This PR contains a fix for bwc tests where now ml-commons has a dependency on job-scheduler plugin for running integ tests. Therefore adding js plugin in test cluster will resolve the dependency failure in test cluster.

Failure logs

https://github.com/opensearch-project/neural-search/actions/runs/13062503692/job/36498500139?pr=1154

> Task :qa:restart-upgrade:testAgainstOldCluster FAILED
Exec output and error:
| Output for ./bin/opensearch-plugin:-> Installing file:/home/runner/work/neural-search/neural-search/qa/restart-upgrade/build/private/artifact_tmp/opensearch-ml-2.19.0.zip
| -> Downloading file:/home/runner/work/neural-search/neural-search/qa/restart-upgrade/build/private/artifact_tmp/opensearch-ml-2.19.0.zip
| -> Failed installing file:/home/runner/work/neural-search/neural-search/qa/restart-upgrade/build/private/artifact_tmp/opensearch-ml-2.19.0.zip

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

| -> Rolling back file:/home/runner/work/neural-search/neural-search/qa/restart-upgrade/build/private/artifact_tmp/opensearch-ml-2.19.0.zip
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

| -> Rolled back file:/home/runner/work/neural-search/neural-search/qa/restart-upgrade/build/private/artifact_tmp/opensearch-ml-2.19.0.zip
| Exception in thread "main" java.lang.IllegalArgumentException: Missing plugin [opensearch-job-scheduler], dependency of [opensearch-ml]
| 	at org.opensearch.plugins.PluginsService.addSortedBundle(PluginsService.java:532)
| 	at org.opensearch.plugins.PluginsService.sortBundles(PluginsService.java:495)
| 	at org.opensearch.plugins.InstallPluginCommand.jarHellCheck(InstallPluginCommand.java:833)
| 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:807)
| 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:852)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:274)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:248)
| 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.Command.main(Command.java:101)
| 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

@vibrantvarun vibrantvarun marked this pull request as ready for review January 31, 2025 20:21
@vibrantvarun vibrantvarun added backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.19 labels Jan 31, 2025
@vibrantvarun vibrantvarun marked this pull request as draft January 31, 2025 20:34
@vibrantvarun
Corrections in the js path
75ab1bc 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun
rebasing
1abbcaf 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun
reverting to original change
c096d38 
Signed-off-by: Varun Jain <[email protected]>
@vibrantvarun vibrantvarun marked this pull request as ready for review January 31, 2025 20:47
@vibrantvarun
Copy link
Member Author

In this PR the rolling upgrade is failing due to #1142

@vibrantvarun
Copy link
Member Author

@heemin32 / @martin-gaievski Can one of guys review it? It has to go in 2.19 backport

@vibrantvarun vibrantvarun merged commit cb97cab into opensearch-project:main Jan 31, 2025
43 of 45 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
@vibrantvarun @github-actions
Adding job scheduler dependency in bwc tests (#1158)
07b68b9 
* Adding job scheduler dependency in bwc tests

Signed-off-by: Varun Jain <[email protected]>

* Fix naming of job scheduler

Signed-off-by: Varun Jain <[email protected]>

* Corrections in the js path

Signed-off-by: Varun Jain <[email protected]>

* reverting to original change

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit cb97cab)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 31, 2025
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
@vibrantvarun @github-actions
Adding job scheduler dependency in bwc tests (#1158)
0b490b1 
* Adding job scheduler dependency in bwc tests

Signed-off-by: Varun Jain <[email protected]>

* Fix naming of job scheduler

Signed-off-by: Varun Jain <[email protected]>

* Corrections in the js path

Signed-off-by: Varun Jain <[email protected]>

* reverting to original change

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit cb97cab)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 31, 2025
Merged
minalsha
minalsha reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vibrantvarun added a commit that referenced this pull request Jan 31, 2025
@opensearch-trigger-bot @vibrantvarun
Adding job scheduler dependency in bwc tests (#1158) (#1160)
de15432 
* Adding job scheduler dependency in bwc tests

Signed-off-by: Varun Jain <[email protected]>

* Fix naming of job scheduler

Signed-off-by: Varun Jain <[email protected]>

* Corrections in the js path

Signed-off-by: Varun Jain <[email protected]>

* reverting to original change

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit cb97cab)

Co-authored-by: Varun Jain <[email protected]>
vibrantvarun added a commit that referenced this pull request Jan 31, 2025
@opensearch-trigger-bot @vibrantvarun
Adding job scheduler dependency in bwc tests (#1158) (#1159)
5a13ec4 
* Adding job scheduler dependency in bwc tests

Signed-off-by: Varun Jain <[email protected]>

* Fix naming of job scheduler

Signed-off-by: Varun Jain <[email protected]>

* Corrections in the js path

Signed-off-by: Varun Jain <[email protected]>

* reverting to original change

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit cb97cab)

Co-authored-by: Varun Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minalsha minalsha minalsha left review comments

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@heemin32 heemin32 heemin32 approved these changes

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.19 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vibrantvarun @heemin32 @minalsha @junqiu-lei