-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial loading implementation for FAISS HNSW #2405
Open
0ctopus13prime
wants to merge
8
commits into
opensearch-project:main
Choose a base branch
from
0ctopus13prime:actual-partial-loading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3f13a57
First partial loading implementation for float[], FAISS HNSW.
9a568fc
Adding KNNVectorDistanceFunction
c60155e
Cover parentIds, filter, idMap
32ad9cc
Fix bug in GroupedDistanceMaxHeap to use childId instead of group id.
ab14eb6
Fix sorting logic in PlainDistanceMaxHeap to return distance in ascen…
adfa4e4
Fix bug in GroupedDistanceMaxHeap sorting logic.
ec2d966
Implemeneted FAISS HNSW partial loading.
c42a6bf
Fixed a bug setting MAX_VALUE after pop in the max-heap.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/main/java/org/opensearch/knn/index/KNNVectorDistanceFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package org.opensearch.knn.index; | ||
|
||
import org.apache.lucene.util.VectorUtil; | ||
|
||
public enum KNNVectorDistanceFunction { | ||
EUCLIDEAN { | ||
@Override | ||
public float distance(float[] vec1, float[] vec2) { | ||
return VectorUtil.squareDistance(vec1, vec2); | ||
} | ||
|
||
@Override | ||
public float distance(byte[] vec1, byte[] vec2) { | ||
return VectorUtil.squareDistance(vec1, vec2); | ||
} | ||
}, | ||
DOT_PRODUCT { | ||
@Override | ||
public float distance(float[] vec1, float[] vec2) { | ||
return -VectorUtil.dotProduct(vec1, vec2); | ||
} | ||
|
||
@Override | ||
public float distance(byte[] vec1, byte[] vec2) { | ||
return -VectorUtil.dotProduct(vec1, vec2); | ||
} | ||
}, | ||
COSINE { | ||
@Override | ||
public float distance(float[] vec1, float[] vec2) { | ||
return VectorUtil.cosine(vec1, vec2); | ||
} | ||
|
||
@Override | ||
public float distance(byte[] vec1, byte[] vec2) { | ||
return VectorUtil.cosine(vec1, vec2); | ||
} | ||
}; | ||
|
||
public abstract float distance(float[] vec1, float[] vec2); | ||
|
||
public abstract float distance(byte[] vec1, byte[] vec2); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temp code. Will revert it back before merging.