Skip to content

More code review comments and refactoring

Codecov / codecov/patch failed Jan 24, 2025 in 1s

62.74% of diff hit (target 70.00%)

View this Pull Request on Codecov

62.74% of diff hit (target 70.00%)

Annotations

Check warning on line 152 in src/main/java/org/opensearch/flowframework/FlowFrameworkPlugin.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/FlowFrameworkPlugin.java#L146-L152 

Added lines #L146 - L152 were not covered by tests

Check warning on line 340 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L340 

Added line #L340 was not covered by tests

Check warning on line 356 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L348-L356 

Added lines #L348 - L356 were not covered by tests

Check warning on line 365 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L359-L365 

Added lines #L359 - L365 were not covered by tests

Check warning on line 370 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L367-L370 

Added lines #L367 - L370 were not covered by tests

Check warning on line 372 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L372 

Added line #L372 was not covered by tests

Check warning on line 374 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L374 

Added line #L374 was not covered by tests

Check warning on line 387 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L387 

Added line #L387 was not covered by tests

Check warning on line 409 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L409 

Added line #L409 was not covered by tests

Check warning on line 424 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L416-L424 

Added lines #L416 - L424 were not covered by tests

Check warning on line 432 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L427-L432 

Added lines #L427 - L432 were not covered by tests

Check warning on line 437 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L434-L437 

Added lines #L434 - L437 were not covered by tests

Check warning on line 439 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L439 

Added line #L439 was not covered by tests

Check warning on line 483 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L483 

Added line #L483 was not covered by tests

Check warning on line 485 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L485 

Added line #L485 was not covered by tests

Check warning on line 556 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L554-L556 

Added lines #L554 - L556 were not covered by tests

Check warning on line 606 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L606 

Added line #L606 was not covered by tests

Check warning on line 612 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L610-L612 

Added lines #L610 - L612 were not covered by tests

Check warning on line 617 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L617 

Added line #L617 was not covered by tests

Check warning on line 648 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L647-L648 

Added lines #L647 - L648 were not covered by tests

Check warning on line 687 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L687 

Added line #L687 was not covered by tests

Check warning on line 689 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L689 

Added line #L689 was not covered by tests

Check warning on line 733 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L731-L733 

Added lines #L731 - L733 were not covered by tests

Check warning on line 801 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L799-L801 

Added lines #L799 - L801 were not covered by tests

Check warning on line 859 in src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java#L857-L859 

Added lines #L857 - L859 were not covered by tests
View more details on Codecov