Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Testing admin password changes #415

Closed
wants to merge 1 commit into from

Conversation

joshpalis
Copy link
Member

Description

PR in Draft, testing changes

Replacing default admin password with an opensearch initial admin password

Issues Resolved

#310

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6e6ed2) 71.83% compared to head (f79bd04) 71.83%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #415   +/-   ##
=========================================
  Coverage     71.83%   71.83%           
  Complexity      613      613           
=========================================
  Files            79       79           
  Lines          3082     3082           
  Branches        237      237           
=========================================
  Hits           2214     2214           
  Misses          763      763           
  Partials        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -200,12 +201,14 @@ ext{
}
}

var adminPassword = System.getProperty("OPENSEARCH_INITIAL_ADMIN_PASSWORD")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this setter should be version based. In case the version being pulled is < 2.12 the password is admin else it should be read from env variable. But in case if security plugin's demo configuration is not being used at all, this logic is not needed at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security plugin's demo configuration isn't directly used, we pull the configuration files from the security plugin and manually set the required cluster settings while setting up a security enabled integration test cluster. Given this, I'll go ahead and close out this PR, as this modification is not necessary for our plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.12.0] Ensure CI/documentation reflect changes to default admin credentials
2 participants