Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for wait_for_completion_timeout Parameter #9138

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

junweid62
Copy link
Contributor

Description

For create workflow page :
documentation for opensearch-project/flow-framework#1009
Screenshot 2025-01-29 at 2 01 50 PM
Screenshot 2025-01-29 at 2 01 57 PM
Screenshot 2025-01-29 at 2 03 26 PM

For provision page:
Screenshot 2025-01-29 at 2 03 21 PM
Screenshot 2025-01-29 at 2 02 14 PM
Screenshot 2025-01-29 at 2 03 26 PM

Issues Resolved

Resolved #9116

Version

2.19 or after

Frontend features

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…completion param description

Signed-off-by: Junwei Dai <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@junweid62 junweid62 changed the title dd Documentation for wait_for_completion_timeout Parameter Add Documentation for wait_for_completion_timeout Parameter Jan 29, 2025
@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.19.0 4 - Doc review PR: Doc review in progress labels Jan 29, 2025
Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws removed the 4 - Doc review PR: Doc review in progress label Feb 3, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @junweid62 Please see my changes and let me know if you have any questions. Thanks!

_automating-configurations/api/create-workflow.md Outdated Show resolved Hide resolved
_automating-configurations/api/create-workflow.md Outdated Show resolved Hide resolved
_automating-configurations/api/create-workflow.md Outdated Show resolved Hide resolved
_automating-configurations/api/provision-workflow.md Outdated Show resolved Hide resolved
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @junweid62!

@kolchfa-aws kolchfa-aws merged commit 3a7bbeb into opensearch-project:main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Introducing Sync Execution for Workflow Provisioning: Adding wait_for_completion_timeout
3 participants