Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for OSB query randomization #8990
base: main
Are you sure you want to change the base?
Add documentation for OSB query randomization #8990
Changes from 4 commits
0f17a0e
543b91f
1135203
c4c7af1
dd67e64
883a25a
a0f668a
578bf32
da62200
1d89075
7dc48e3
28a8a5b
621427f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 37: In the second sentence, the second phrase doesn't appear to logically follow the first. Do we mean something like "
alpha
represents a parameter that controls the spread of the distribution"? In the last sentence, what is meant by "low indexes" and "high indexes"? Please clarify.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an explanation of the
Zipf
law of distribution. In our case,i^alpha
would represent thenth
common term. The sentence, as written, assumes previous knowledge of theZipf
law, however, @peteralfonsi, should we go a little deeper on this explanation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @peteralfonsi, by "high indexes" and "low indexes", do we mean the order appear in the saved list relative to their terms?
Check failure on line 42 in _benchmark/user-guide/optimizing-benchmarks/randomizing-queries.md
GitHub Actions / style-job
Check failure on line 58 in _benchmark/user-guide/optimizing-benchmarks/randomizing-queries.md
GitHub Actions / style-job