Add migrations section #8873
Merged
Add migrations section #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archer <[email protected]>
Naarcha-AWS
requested review from
kolchfa-aws,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
kolchfa-aws
reviewed
Dec 4, 2024
| @@ -2,18 +2,20 @@ | |||
| layout: default | |||
| title: Getting started with data migration | |||
| nav_order: 10 | |||
There was a problem hiding this comment.
The children of this page are not displaying because the parent does not have has_children: true specified.
There was a problem hiding this comment.
There aren't any child pages for this section.
There was a problem hiding this comment.
There were child pages for "Deploying Migration Assistant" that was not displaying, however. I fixed that in my latest commit.
There was a problem hiding this comment.
You're right - it was for the "Deploying Migration Assistant" topic, but they are still not displaying.
| @@ -2,18 +2,20 @@ | |||
| layout: default | |||
| title: Getting started with data migration | |||
| nav_order: 10 | |||
| redirect_from: | |||
| - /upgrade-to/upgrade-to/ | |||
| - /upgrade-to/snapshot-migrate/ | |||
| --- | |||
There was a problem hiding this comment.
Right now, steps have a mix of verbs in imperative and gerund forms. All steps should have verbs in imperative form.
There was a problem hiding this comment.
IMO, steps should be in the imperative form, so "Configure and deploy" rather than "Configuring and deploying". cc: @natebower
There was a problem hiding this comment.
Switched steps to imperative form.
_migration-assistant/migration-console/migration-console-commands-references.md
Show resolved
Hide resolved
_migration-assistant/migration-console/migration-console-commands-references.md
Show resolved
Hide resolved
_migration-assistant/migration-phases/assessing-your-cluster-for-migration.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
commented
Dec 4, 2024
_migration-assistant/migration-phases/assessing-your-cluster-for-migration.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
…or-migration.md Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
kolchfa-aws
approved these changes
Dec 4, 2024
Signed-off-by: Archer <[email protected]>
Signed-off-by: Archer <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-8873-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 866405197e8f656ec82115c5f2e6569c77d16a07
# Push it to GitHub
git push --set-upstream origin backport/backport-8873-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18Then, create a pull request where the |
Naarcha-AWS
added a commit
that referenced
this pull request
Dec 5, 2024
* Add migrations section. Signed-off-by: Archer <[email protected]> * Add back upgrade pages. Make them less migration focused. Signed-off-by: Archer <[email protected]> * Add back in upgrade pages. Signed-off-by: Archer <[email protected]> * Remove upgrade section. Add redirects. Signed-off-by: Archer <[email protected]> * Update migration-console-commands-references.md Signed-off-by: Naarcha-AWS <[email protected]> * Implement doc review. Signed-off-by: Archer <[email protected]> * Fix getting started headers. Signed-off-by: Archer <[email protected]> * Fix parent child relationship for Deploying migration assistant Signed-off-by: Archer <[email protected]> * Update _migration-assistant/migration-phases/assessing-your-cluster-for-migration.md Signed-off-by: Naarcha-AWS <[email protected]> * Additional feedback Signed-off-by: Archer <[email protected]> * Add permalink for migration console Signed-off-by: Archer <[email protected]> * Add redirects for index pages. Signed-off-by: Archer <[email protected]> * Final edits. Signed-off-by: Archer <[email protected]> * Fix headings. Signed-off-by: Archer <[email protected]> * Add copy buttons. Signed-off-by: Archer <[email protected]> * Last copy button. Signed-off-by: Archer <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit 8664051)
Naarcha-AWS
added a commit
that referenced
this pull request
Dec 5, 2024
* Add migrations section (#8873) * Add migrations section. Signed-off-by: Archer <[email protected]> * Add back upgrade pages. Make them less migration focused. Signed-off-by: Archer <[email protected]> * Add back in upgrade pages. Signed-off-by: Archer <[email protected]> * Remove upgrade section. Add redirects. Signed-off-by: Archer <[email protected]> * Update migration-console-commands-references.md Signed-off-by: Naarcha-AWS <[email protected]> * Implement doc review. Signed-off-by: Archer <[email protected]> * Fix getting started headers. Signed-off-by: Archer <[email protected]> * Fix parent child relationship for Deploying migration assistant Signed-off-by: Archer <[email protected]> * Update _migration-assistant/migration-phases/assessing-your-cluster-for-migration.md Signed-off-by: Naarcha-AWS <[email protected]> * Additional feedback Signed-off-by: Archer <[email protected]> * Add permalink for migration console Signed-off-by: Archer <[email protected]> * Add redirects for index pages. Signed-off-by: Archer <[email protected]> * Final edits. Signed-off-by: Archer <[email protected]> * Fix headings. Signed-off-by: Archer <[email protected]> * Add copy buttons. Signed-off-by: Archer <[email protected]> * Last copy button. Signed-off-by: Archer <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> (cherry picked from commit 8664051) * Fix merge conflicts Signed-off-by: Archer <[email protected]> * Delete _migrations directory Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Archer <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the old migrations section and removes the "upgrade_to" directory. Can add redirects from the upgrade pages, if necessary. However, no links exist to the current upgrade flow in the rest of the documentation.
Issues Resolved
Closes #8499
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.