Improved documentation of supported model types in LTR plugin #8831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ankLib models and showing RankNet Example Signed-off-by: Johannes Peter <[email protected]>
JohannesDaniel
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
approved these changes
Dec 4, 2024
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]>
|
@kolchfa-aws Thank you, just committed all of your suggestions. |
natebower
reviewed
Dec 5, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Enhanced LTR documentation by explicitly mentioning other supported RankLib models and showing RankNet Example Signed-off-by: Johannes Peter <[email protected]> * Update _search-plugins/ltr/training-models.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]> * Update _search-plugins/ltr/training-models.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]> * Update _search-plugins/ltr/training-models.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Johannes Peter <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Johannes Peter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit e770b61) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws
added a commit
that referenced
this pull request
Dec 6, 2024
…#8894) * Enhanced LTR documentation by explicitly mentioning other supported RankLib models and showing RankNet Example * Update _search-plugins/ltr/training-models.md * Update _search-plugins/ltr/training-models.md * Update _search-plugins/ltr/training-models.md * Apply suggestions from code review --------- (cherry picked from commit e770b61) Signed-off-by: Johannes Peter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced LTR documentation by explicitly mentioning other supported RankLib models and showing RankNet Example
Issues Resolved
Closes opensearch-project/opensearch-learning-to-rank-base#72
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.