Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Document OPENSEARCH_JAVA_HOME #411

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

reta
Copy link
Contributor

@reta reta commented Feb 15, 2022

Signed-off-by: Andriy Redko [email protected]

Description

Documents usage of the OPENSEARCH_JAVA_HOME environment variable

Issues Resolved

Closes #396

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner February 15, 2022 17:13
@reta
Copy link
Contributor Author

reta commented Feb 15, 2022

@stockholmux @dblock the last one, documentation updates :)

_opensearch/install/compatibility.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS self-requested a review February 15, 2022 19:12
@Naarcha-AWS
Copy link
Collaborator

@reta , we recently added a DCO check that requires you to sign off your commits. For information on how to fix your commit, refer to this page.

@reta
Copy link
Contributor Author

reta commented Feb 15, 2022

@reta , we recently added a DCO check that requires you to sign off your commits. For information on how to fix your commit, refer to this page.

Huhh .. It is signed but committing Github changes breaks it ... I will fix that ...

@Naarcha-AWS
Copy link
Collaborator

@reta , we recently added a DCO check that requires you to sign off your commits. For information on how to fix your commit, refer to this page.

Huhh .. It is signed but committing Github changes breaks it ... I will fix that ...

@reta: You need to sign every commit you make to OpenSearch docs. It looks like by commiting my suggestion, GitHub signed on my behalf but didn't sign on yours [Which is odd]. A fast fix would be to close this PR, open a new branch, and then open a new PR with a signed commit.

I'm going to investigate a workaround for committing suggestions.

_opensearch/install/compatibility.md Outdated Show resolved Hide resolved
@keithhc2
Copy link
Contributor

I'll check in with our devs and see when we can merge in this PR. Thanks @reta!

@reta
Copy link
Contributor Author

reta commented Feb 15, 2022

@keithhc2 thank you, just to save you some time (hopefully): the change is for 1.3.0+

@keithhc2 keithhc2 added the upcoming release Don't merge until the version or feature is available label Feb 15, 2022
@Naarcha-AWS Naarcha-AWS added the v1.3.0 Issue: Any issues related to version v1.3.x label Mar 8, 2022
@Naarcha-AWS Naarcha-AWS merged commit 27f322c into opensearch-project:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming release Don't merge until the version or feature is available v1.3.0 Issue: Any issues related to version v1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Document OPENSEARCH_JAVA_HOME
3 participants