Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudwatch logs sink #5406

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

kkondaka
Copy link
Collaborator

@kkondaka kkondaka commented Feb 3, 2025

Description

  1. Include cloudwatch logs sink build in DataPrepper
  2. Added Integration test
  3. Fixed a bug about not honoring log interval threshold config

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [X ] New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • [ X] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Krishna Kondaka <[email protected]>
logStreamName = createLogStream(logGroupName);
pluginMetrics = mock(PluginMetrics.class);
counter = mock(Counter.class);
lenient().doAnswer((a)-> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see you validating this. So you can probably just remove these lines.

private ThresholdConfig thresholdConfig;

@Mock
CloudWatchLogsSinkConfig cloudWatchLogsSinkConfig;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make private

Signed-off-by: Krishna Kondaka <[email protected]>
@kkondaka kkondaka merged commit 81c1c84 into opensearch-project:main Feb 5, 2025
64 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants