Add stateful buffer for lambda sink #5354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srikanth Govindarajan <[email protected]>
srikanthjg
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Srikanth Govindarajan <[email protected]>
san81
reviewed
Jan 24, 2025
|
|
||
| // The partial buffer that may not yet have reached threshold. | ||
| // Access must be synchronized | ||
| private Buffer statefulBuffer; |
There was a problem hiding this comment.
This should handle concurrent actions?
There was a problem hiding this comment.
yes, all i have used "synchronized" on the methods where this is used. In s3 sink, they use reentrant lock to handle something similar.
Signed-off-by: Srikanth Govindarajan <[email protected]>
san81
reviewed
Jan 24, 2025
Comment on lines
+271
to
+273
| for (Buffer buf : buffersToFlush) { | ||
| combinedRecords.addAll(buf.getRecords()); | ||
| } |
There was a problem hiding this comment.
I may be not clear on the overall approach here but Why are we combining the buffers here? also, may be not a big deal but we are creating additional copy of the payload here.
san81
reviewed
Jan 24, 2025
|
|
||
| verify(numberOfRecordsFailedCounter, times(1)).increment(1); | ||
| // Utility to set private fields | ||
| private static void setPrivateField(Object target, String fieldName, Object value) { |
There was a problem hiding this comment.
There is a data-prepper-test-common module that has these kind of common reusable methods used for test cases. We can reuse these utilities from there and avoid adding these methods in every plugin.
Signed-off-by: Srikanth Govindarajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Stateful Buffering to LambdaSink
Issues Resolved
Resolves #5353
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.