Report SQS message delay immediately after message is received, and as 0 when there are no messages found in queue #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
sb2k16,
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
force-pushed
the
SqsMetricReport
branch
from
74601e0 to
18a883e
Compare
graytaylor0
changed the title
jmsusanto
approved these changes
Jan 15, 2025
dlvenable
previously approved these changes
Jan 15, 2025
| @@ -228,6 +231,10 @@ && isEventBridgeEventTypeCreated(parsedMessage)) { | |||
| LOG.info("Received {} messages from SQS. Processing {} messages.", s3EventNotificationRecords.size(), parsedMessagesToRead.size()); | |||
|
|
|||
| for (ParsedMessage parsedMessage : parsedMessagesToRead) { | |||
| sqsMessageDelayTimer.record(Duration.between( | |||
There was a problem hiding this comment.
This change is untested. We can use a Mockito inOrder to verify that this happens before or after a certain part in the tests. I'm guessing there is an existing test that could be updated to use inOrder to ensure this behavior remains consistent.
e.g.
InOrder inOrder = inOrder(s3Service, sqsMessageDelayTimer);
inOrder.verify(sqsMessageDelayTimer).record(...);
inOrder.verify(s3Service).addS3Object(...);
There was a problem hiding this comment.
Makes sense I can make that change
kkondaka
previously approved these changes
Jan 15, 2025
graytaylor0
force-pushed
the
SqsMetricReport
branch
from
18a883e to
207524a
Compare
…s 0 when there are no messages found in queue Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
SqsMetricReport
branch
from
207524a to
7fad3bb
Compare
dlvenable
approved these changes
Jan 15, 2025
kkondaka
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are no messages pulled from the queue, the sqsMessageDelay metric is not being reported. When there are no messages pulled from the queue, that means the queue is empty and this can be reported as a delay of 0.
Additionally, the sqsMessageDelay metric is currently reported at the time the S3 object is processed. This means that with
maximum_messagesat 10, for example, the 10th message will report high delay because it may take a long time for the previous 9 objects to be processed.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.