-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing core package in the data-prepper-core module #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
changed the title
core package introduced in the data-prepper-core module
Introducing core package in the data-prepper-core module
Oct 14, 2024
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
san81
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
October 14, 2024 05:54
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
dlvenable
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @san81 for this very help contribution. This is a good clean-up to the project.
I have a couple comments about some classes that perhaps should not be moved. Other than that, this looks good to me.
...er-pipeline-parser/src/main/java/org/opensearch/dataprepper/core/validation/PluginError.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opensearch/dataprepper/core/logging/SensitiveArgumentMaskingConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
… they belong Signed-off-by: Santhosh Gandhe <[email protected]>
…ession evaluation changes Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
kkondaka
approved these changes
Oct 15, 2024
dlvenable
approved these changes
Oct 15, 2024
san81
added a commit
to san81/data-prepper
that referenced
this pull request
Oct 17, 2024
…project#5056) core package introduced in the data-prepper-core module Signed-off-by: Santhosh Gandhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR looks huge but there is no real code change. It is only a package restructuring.
Organizing core data prepper code base into a package named
core
so that we can minimize the spring component scanning to the required packages and avoids rescanning of the same packages when we initiate plugin specific isolated spring context initialization. The following modules are modified to in order and their corresponding spring context scanning package names modifiedorg.opensearch.dataprepper
pacakge under data-prepper-core module is now moved toorg.opensearch.dataprepper.core
core
package but only moved two classes related to DataPrepper Argument classesorg.opensearch.dataprepper.validation
package toorg.opensearch.dataprepper.core.validation
package.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.