Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing core package in the data-prepper-core module #5056

Merged
merged 20 commits into from
Oct 15, 2024

Conversation

san81
Copy link
Contributor

@san81 san81 commented Oct 14, 2024

Description

PR looks huge but there is no real code change. It is only a package restructuring.

Organizing core data prepper code base into a package named core so that we can minimize the spring component scanning to the required packages and avoids rescanning of the same packages when we initiate plugin specific isolated spring context initialization. The following modules are modified to in order and their corresponding spring context scanning package names modified

  • org.opensearch.dataprepper pacakge under data-prepper-core module is now moved to org.opensearch.dataprepper.core
  • Under data-prepper-main module introduced core package but only moved two classes related to DataPrepper Argument classes
  • Under data-prepper-pipeline module classes under org.opensearch.dataprepper.validation package to org.opensearch.dataprepper.core.validation package.
  • All the corresponding Test classes are also moved relative to their original class file
  • Rest of the changes are just to fix the import statements in other classes where the refactored classes are references.

Issues Resolved

  • Avoids double scanning of the class files while initializing plugin specific isolated spring DI context
  • Enables to ingest any Plugin configuration as a bean

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@san81 san81 changed the title core package introduced in the data-prepper-core module Introducing core package in the data-prepper-core module Oct 14, 2024
@san81 san81 marked this pull request as ready for review October 14, 2024 05:54
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @san81 for this very help contribution. This is a good clean-up to the project.

I have a couple comments about some classes that perhaps should not be moved. Other than that, this looks good to me.

san81 added 2 commits October 14, 2024 14:22
Signed-off-by: Santhosh Gandhe <[email protected]>
Signed-off-by: Santhosh Gandhe <[email protected]>
@san81 san81 requested a review from dlvenable October 14, 2024 21:46
san81 added 2 commits October 15, 2024 10:08
Signed-off-by: Santhosh Gandhe <[email protected]>
@dlvenable dlvenable merged commit 3e220d4 into opensearch-project:main Oct 15, 2024
48 of 50 checks passed
san81 added a commit to san81/data-prepper that referenced this pull request Oct 17, 2024
…project#5056)

core package introduced in the data-prepper-core module

Signed-off-by: Santhosh Gandhe <[email protected]>
@san81 san81 deleted the intro-core-pkg branch October 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants