Set default value of flattenAttributes to true in Otel metrics source #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Krishna Kondaka <[email protected]>
graytaylor0
reviewed
Feb 27, 2024
| @@ -85,7 +81,7 @@ public Collection<Record<? extends Metric>> doExecute(Collection<Record<?>> reco | |||
| for (Record<?> rec : records) { | |||
| if ((rec.getData() instanceof Event)) { | |||
| Record<? extends Metric> newRecord = (Record<? extends Metric>)rec; | |||
| if (otelMetricsRawProcessorConfig.getFlattenAttributesFlag() || | |||
| if (!otelMetricsRawProcessorConfig.getFlattenAttributesFlag() || | |||
There was a problem hiding this comment.
Can you explain why this is being negated?
There was a problem hiding this comment.
It's true by default. Only when it is set to false in the config, we call JacksonMetric.setFlattenAttributes(false)
Signed-off-by: Krishna Kondaka <[email protected]>
graytaylor0
approved these changes
Feb 27, 2024
dlvenable
reviewed
Feb 27, 2024
|
@dlvenable. No It doesn't change existing setup |
dlvenable
approved these changes
Feb 27, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
added a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Krishna Kondaka <[email protected]> Co-authored-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set default value of flattenAttributes to true in Otel metrics source.
Modify the OTEL metrics source to create events/records with flatten attributes set to true.
If OTEL processor config changes the flatten attributes to flase, then change it false in the processor.
OTEL metrics always have been implemented with flattening the attributes(ie fields inside "attributes" field are moved to the root). We have added option to not flatten some time back. But that's not used by anyone (that I know of). When the previous PR which moved the creation of OTEL metrics records to OTEL source (instead of otel processor) I picked the default to false and it is changed to true in the processor. But that was unnecessary also hit a bug due to valid characters in a key. This new approach will avoid it.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.