Support Kafka SASL_SSL/SSL security protocol for self signed certificate in Kafka Consumer #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinujoh
requested review from
chenqi0805,
engechas,
graytaylor0,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
…ate in Kafka Consumer Signed-off-by: Dinu John <[email protected]>
…ate in Kafka Consumer Signed-off-by: Dinu John <[email protected]>
dlvenable
requested changes
Feb 23, 2024
...s/src/main/java/org/opensearch/dataprepper/plugins/kafka/configuration/EncryptionConfig.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/opensearch/dataprepper/plugins/kafka/configuration/EncryptionConfig.java
Outdated
Show resolved
Hide resolved
...s/src/main/java/org/opensearch/dataprepper/plugins/kafka/configuration/EncryptionConfig.java
Outdated
Show resolved
Hide resolved
- Renamed the field names for certificate, truststore and password. - Removed redundant information from build.gradle Signed-off-by: Dinu John <[email protected]>
…ate in Kafka Consumer - Add the copyright block to build.gradle Signed-off-by: Dinu John <[email protected]>
dlvenable
previously approved these changes
Feb 23, 2024
kkondaka
reviewed
Feb 23, 2024
| properties.put(SECURITY_PROTOCOL, "SASL_SSL"); | ||
| setSecurityProtocolSSLProperties(properties, encryptionConfig); | ||
| } else { // EncryptionType.NONE | ||
| properties.put(SECURITY_PROTOCOL, "SASL_PLAINTEXT"); | ||
| } |
There was a problem hiding this comment.
Why switch the statements here?
There was a problem hiding this comment.
encryptionType can be null, so had added checkEncryptionType method that does null check.
I could have kept the same order with if condition if (checkEncryptionType(encryptionConfig, EncryptionType.NONE)) {, but since we are handling addition things for SSL, I reversed the order.
| @@ -83,6 +83,10 @@ public class KafkaSecurityConfigurer { | |||
| private static final String REGISTRY_BASIC_AUTH_USER_INFO = "schema.registry.basic.auth.user.info"; | |||
|
|
|||
| private static final int MAX_KAFKA_CLIENT_RETRIES = 360; // for one hour every 10 seconds | |||
| private static final String SSL_ENGINE_FACTORY_CLASS = "ssl.engine.factory.class"; | |||
| private static final String CERTIFICATE_CONTENT = "certificateContent"; | |||
There was a problem hiding this comment.
Is this valid name? I don't seem to find it.
There was a problem hiding this comment.
It's internal property that is used in CustomClientSslEngineFactory class to get the certificate content to setup TrustManager.
kkondaka
previously approved these changes
Feb 23, 2024
Signed-off-by: Dinu John <[email protected]>
dlvenable
approved these changes
Feb 23, 2024
kkondaka
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Kafka SASL_SSL/SSL security protocol for self signed certificate in Kafka Consumer
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.