Support for logging MDC in the Kafka buffer #4131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds logging MDC to the
kafka
buffer to disambiguate it against thekafka
sink. Entry points into theBuffer
interface set the MDC value. Also, the threads which thekafka
buffer directly creates will have MDC and also have a useful thread name.This MDC is now available for both Data Prepper loggers and Apache Kafka loggers.
One limitation is that the MDC is not available for the
KafkaProducer
. This is because the internal Apache Kafka libraries create that thread and appear to have no way to influence it.Issues Resolved
First part of #4126
I plan to follow up with more changes for the
kafka
sink in a subsequent PR.Results
I changed the Log4j configuration to include the
kafkaPluginType
MDC value.Here is a sample of the logs produced:
And here are some sample logs from outside of Kafka
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.