Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Checkstyle validation to ensure that the Guava cache is not used. #3631

Merged
merged 1 commit into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,9 @@
-->
<module name="ModifierOrder" />

<module name="ImportControl">
<property name="file" value="${config_loc}/import-control.xml"/>
</module>

</module>
</module>
14 changes: 14 additions & 0 deletions config/checkstyle/import-control.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0"?>
<!--
~ Copyright OpenSearch Contributors
~ SPDX-License-Identifier: Apache-2.0
-->

<!DOCTYPE import-control PUBLIC
"-//Checkstyle//DTD ImportControl Configuration 1.4//EN"
"https://checkstyle.org/dtds/import_control_1_4.dtd">

<import-control pkg="org.opensearch.dataprepper" strategyOnMismatch="allowed">
<!-- Prefer Caffeine -->
<disallow pkg="com.google.common.cache"/>
</import-control>
Loading