Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create network policy for aoss source. #3613

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Create network policy for aoss source. #3613

merged 1 commit into from
Nov 10, 2023

Conversation

asuresh8
Copy link
Contributor

@asuresh8 asuresh8 commented Nov 8, 2023

Description

Allow AOSS source to create/update a network policy during initialization

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tested with:

version: "2"
log-pipeline:
  source:
    opensearch:
      hosts: [ "https://cw4c6ujthlys4gf4qp7c.us-east-1.aoss.amazonaws.com" ]
      indices:
        include:
          - index_name_regex: ".*"      
      aws:
        sts_role_arn: "arn:aws:iam::841692598829:role/FizzyE2ETestPipelineExecutionRole"
        region: "us-east-1"
        serverless: true
        serverless_options:
          network_policy_name: "new-adi-test-collection"
          collection_name: "adi-test-collection"
          vpce_id: "vpce-0998c653f94b15f22"
  sink:
    - stdout:

@asuresh8 asuresh8 force-pushed the opensearch_source_refactor branch from e0f58d9 to 6fddda1 Compare November 8, 2023 22:08
chenqi0805
chenqi0805 previously approved these changes Nov 9, 2023
View reviewed changes
@asuresh8 asuresh8 force-pushed the opensearch_source_refactor branch from 6fddda1 to 5614bac Compare November 9, 2023 18:39
dlvenable
dlvenable previously approved these changes Nov 9, 2023
View reviewed changes
@asuresh8 asuresh8 force-pushed the opensearch_source_refactor branch from 5614bac to 410e9e1 Compare November 9, 2023 19:15
graytaylor0
graytaylor0 previously approved these changes Nov 10, 2023
View reviewed changes
...rch/src/main/java/org/opensearch/dataprepper/plugins/source/opensearch/OpenSearchSource.java Outdated
openSearchSourceConfiguration.getAwsAuthenticationOptions());
System.out.println(maybeServerlessOptions.toString());
if (maybeServerlessOptions.isPresent()) {
System.out.println("PRESENT!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove the print statement

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good catch. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching! Fixed.

dlvenable
dlvenable requested changes Nov 10, 2023
View reviewed changes
...rch/src/main/java/org/opensearch/dataprepper/plugins/source/opensearch/OpenSearchSource.java Outdated
openSearchSourceConfiguration.getAwsAuthenticationOptions());
System.out.println(maybeServerlessOptions.toString());
if (maybeServerlessOptions.isPresent()) {
System.out.println("PRESENT!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good catch. Thanks!

@asuresh8 asuresh8 force-pushed the opensearch_source_refactor branch from 410e9e1 to d0bfac2 Compare November 10, 2023 19:59
@dlvenable dlvenable merged commit c3c35da into opensearch-project:main Nov 10, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graytaylor0 graytaylor0 graytaylor0 approved these changes

@dlvenable dlvenable dlvenable approved these changes

@chenqi0805 chenqi0805 chenqi0805 left review comments

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@asifsmohammed asifsmohammed Awaiting requested review from asifsmohammed

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asuresh8 @dlvenable @chenqi0805 @graytaylor0