Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opensearch source into same module as opensearch sink. #3607

Merged

Conversation

asuresh8
Copy link
Contributor

@asuresh8 asuresh8 commented Nov 8, 2023

This change is required to share code between the source and sink plugins.

Description

move the opensearch source module into the existing sink module

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please also remove this line:

include 'data-prepper-plugins:opensearch-source'

This change is required to share code between the source and sink
plugins.

Signed-off-by: Adi Suresh <[email protected]>
@asuresh8 asuresh8 force-pushed the opensearch_source_refactor branch from 8a050a3 to 9cec039 Compare November 8, 2023 16:39
@asuresh8
Copy link
Contributor Author

asuresh8 commented Nov 8, 2023

Cool removed the opensearch-source from settings.gradle.

@dlvenable dlvenable merged commit b80b565 into opensearch-project:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants