[Bug]Support for date range in report generation #524
Conversation
…ation Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 71.19% 71.20%
=======================================
Files 31 31
Lines 2052 2066 +14
Branches 454 460 +6
=======================================
+ Hits 1461 1471 +10
- Misses 585 589 +4
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
public/components/report_definitions/create/create_report_definition.tsx
Outdated
Show resolved
Hide resolved
| timeFrom: Date; | ||
| timeTo: Date; | ||
| } | ||
|
|
||
| export function CreateReport(props: { [x: string]: any; setBreadcrumbs?: any; httpClient?: any; chrome: any }) { | ||
| export function CreateReport(props: { |
There was a problem hiding this comment.
nit, i know this naming is not from this PR. but use createReport? And is it possible to start adding types for these any?
| setShowTimeRangeError(true); | ||
| error = true; | ||
| } | ||
| else{ |
…nition.tsx Co-authored-by: Joshua Li <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]>
the reports being created always took the time diff as the current time minus the duration so the backend parameters just have now-duration for beginTime and endTime |
But i see the other PR removed |
yes that is correct I removed the logic for duration, I can add it back for older reports support |
Signed-off-by: sumukhswamy <[email protected]>
|
Have updated the backend PR to work for the older params and new ones as well |
Description
While generating reports the time picker which shows the time from and time to is not working
it auto selects the range as 'Now' and the duration specified, This happens to the edit functionality of the reports as well.
Fix after
https://github.com/user-attachments/assets/401ec030-7b92-4647-89e9-d77f240377e3
Issues Resolved
#414
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.