linter changes

Signed-off-by: sumukhswamy <[email protected]>
opensearch-project · Feb 5, 2025 · 4a2ed80 · 4a2ed80
1 parent e777586
commit 4a2ed80
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 47 deletions.
diff --git a/public/components/report_definitions/create/create_report_definition.tsx b/public/components/report_definitions/create/create_report_definition.tsx
@@ -23,35 +23,35 @@ import {
 } from '../../utils/utils';
 import { definitionInputValidation } from '../utils/utils';
 
-interface reportParamsType {
+interface ReportParamsType {
   report_name: string;
   report_source: string;
   description: string;
-  core_params: visualReportParams | dataReportParams;
+  core_params: VisualReportParams | DataReportParams;
 }
-interface visualReportParams {
+interface VisualReportParams {
   base_url: string;
   report_format: string;
   header: string;
   footer: string;
   time_duration: string;
-  timeRangeParams: timeRangeParams;
+  timeRangeParams: TimeRangeParams;
 }
 
-interface dataReportParams {
+interface DataReportParams {
   saved_search_id: number;
   base_url: string;
   report_format: string;
   time_duration: string;
-  timeRangeParams: timeRangeParams;
+  timeRangeParams: TimeRangeParams;
 }
-interface triggerType {
+interface TriggerType {
   trigger_type: string;
   trigger_params?: any;
 }
 
-interface deliveryType {
-  configIds: Array<string>;
+interface DeliveryType {
+  configIds: string[];
   title: string;
   textDescription: string;
   htmlDescription: string;
@@ -79,13 +79,13 @@ interface Cron {
   };
 }
 
-export interface reportDefinitionParams {
-  report_params: reportParamsType;
-  delivery: deliveryType;
-  trigger: triggerType;
+export interface ReportDefinitionParams {
+  report_params: ReportParamsType;
+  delivery: DeliveryType;
+  trigger: TriggerType;
 }
 
-export interface timeRangeParams {
+export interface TimeRangeParams {
   timeFrom: Date;
   timeTo: Date;
 }
@@ -98,7 +98,7 @@ export function CreateReport(props: {
 }) {
   const { chrome } = props;
 
-  let createReportDefinitionRequest: reportDefinitionParams = {
+  let createReportDefinitionRequest: ReportDefinitionParams = {
     report_params: {
       report_name: '',
       report_source: '',
@@ -199,36 +199,18 @@ export function CreateReport(props: {
     addErrorOnCreateToastHandler(errorType);
   };
 
-  const addInvalidTimeRangeToastHandler = () => {
-    const errorToast = {
-      title: i18n.translate(
-        'opensearch.reports.createReportDefinition.error.invalidTimeRange',
-        { defaultMessage: 'Invalid time range selected.' }
-      ),
-      color: 'danger',
-      iconType: 'alert',
-      id: 'timeRangeErrorToast',
-    };
-    // @ts-ignore
-    setToasts(toasts.concat(errorToast));
-  };
-
-  const handleInvalidTimeRangeToast = () => {
-    addInvalidTimeRangeToastHandler();
-  };
-
   const removeToast = (removedToast: { id: string }) => {
     setToasts(toasts.filter((toast: any) => toast.id !== removedToast.id));
   };
 
-  let timeRange = {
+  const NewTimeRange = {
     timeFrom: new Date(),
     timeTo: new Date(),
   };
 
   const createNewReportDefinition = async (
-    metadata: reportDefinitionParams,
-    timeRange: timeRangeParams
+    metadata: ReportDefinitionParams,
+    timeRange: TimeRangeParams
   ) => {
     const { httpClient } = props;
     //TODO: need better handle
@@ -329,8 +311,8 @@ export function CreateReport(props: {
           edit={false}
           editDefinitionId={''} // empty string since we are coming from create
           reportDefinitionRequest={createReportDefinitionRequest}
-          httpClientProps={props['httpClient']}
-          timeRange={timeRange}
+          httpClientProps={props.httpClient}
+          timeRange={NewTimeRange}
           showSettingsReportNameError={showSettingsReportNameError}
           settingsReportNameErrorMessage={settingsReportNameErrorMessage}
           showSettingsReportSourceError={showSettingsReportSourceError}
@@ -359,7 +341,7 @@ export function CreateReport(props: {
               onClick={() =>
                 createNewReportDefinition(
                   createReportDefinitionRequest,
-                  timeRange
+                  NewTimeRange
                 )
               }
               id={'createNewReportDefinition'}

diff --git a/public/components/report_definitions/delivery/delivery.tsx b/public/components/report_definitions/delivery/delivery.tsx
@@ -25,7 +25,7 @@ import {
   testMessageFailureMessage,
 } from './delivery_constants';
 import 'react-mde/lib/styles/css/react-mde-all.css';
-import { reportDefinitionParams } from '../create/create_report_definition';
+import { ReportDefinitionParams } from '../create/create_report_definition';
 import ReactMDE from 'react-mde';
 import { converter } from '../utils';
 import { getAvailableNotificationsChannels } from '../../main/main_utils';
@@ -41,7 +41,7 @@ export let includeDelivery = false;
 export type ReportDeliveryProps = {
   edit: boolean;
   editDefinitionId: string;
-  reportDefinitionRequest: reportDefinitionParams;
+  reportDefinitionRequest: ReportDefinitionParams;
   httpClientProps: any;
   showDeliveryChannelError: boolean;
   deliveryChannelError: string;

diff --git a/public/components/report_definitions/report_settings/report_settings.tsx b/public/components/report_definitions/report_settings/report_settings.tsx
@@ -35,8 +35,8 @@ import {
 import ReactMde from 'react-mde';
 import 'react-mde/lib/styles/css/react-mde-all.css';
 import {
-  reportDefinitionParams,
-  timeRangeParams,
+  ReportDefinitionParams,
+  TimeRangeParams,
 } from '../create/create_report_definition';
 import {
   parseInContextUrl,
@@ -59,9 +59,9 @@ import { ReportTrigger } from '../report_trigger';
 type ReportSettingProps = {
   edit: boolean;
   editDefinitionId: string;
-  reportDefinitionRequest: reportDefinitionParams;
+  reportDefinitionRequest: ReportDefinitionParams;
   httpClientProps: any;
-  timeRange: timeRangeParams;
+  timeRange: TimeRangeParams;
   showSettingsReportNameError: boolean;
   settingsReportNameErrorMessage: string;
   showSettingsReportSourceError: boolean;

diff --git a/public/components/report_definitions/report_trigger/report_trigger.tsx b/public/components/report_definitions/report_trigger/report_trigger.tsx
@@ -21,7 +21,7 @@ import {
   EuiCompressedFieldNumber,
 } from '@elastic/eui';
 import moment, { Moment } from 'moment';
-import { reportDefinitionParams } from '../create/create_report_definition';
+import { ReportDefinitionParams } from '../create/create_report_definition';
 import {
   SCHEDULE_RECURRING_OPTIONS,
   INTERVAL_TIME_PERIODS,
@@ -36,7 +36,7 @@ import { TimezoneSelect } from './timezone';
 type ReportTriggerProps = {
   edit: boolean;
   editDefinitionId: string;
-  reportDefinitionRequest: reportDefinitionParams;
+  reportDefinitionRequest: ReportDefinitionParams;
   httpClientProps: any;
   showTriggerIntervalNaNError: boolean;
   showCronError: boolean;