Fix broken osd functional test repo #189
Conversation
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya <[email protected]>
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
| @@ -78,7 +79,7 @@ export default class Main extends Component<MainProps, MainState> { | |||
| 'ses_account', | |||
| 'email_group', | |||
| ], | |||
| tooltipSupport: serverFeatures.tooltipSupport, | |||
| tooltipSupport: false, | |||
There was a problem hiding this comment.
not really, this is when serverFeatures is null, we should assign some boolean to tooltip
|
Could you please add a video in the description to show the notification is healthy with the fix |
Signed-off-by: Riya Saxena <[email protected]>
|
Can we fix the reference in server folder, eg. https://github.com/opensearch-project/dashboards-notifications/pull/188/files#diff-6495f662f11eb9366b891c845ddac043c64b34f3a11695a2bdb0d55f58169d4cR14 |
Signed-off-by: Riya Saxena <[email protected]>
There was a problem hiding this comment.
LGTM, we can wait until https://github.com/opensearch-project/dashboards-notifications/actions/runs/8824156128/job/24226041378?pr=189 succeed before merging
There was a problem hiding this comment.
Overall look good to me, since the CHANNEL_TYPE and BACKEND_CHANNEL_TYPE are the only constant that used in server folder but defined in public folder previously, this fix will be fine for now. But for long term, I prefer to moving all the shared utils under common folder.
i agree |
|
Should close #185 |
|
Could we backport this fix to 2.x? @AWSHurneyt @SuZhou-Joe |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-189-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e59708146ddb77b350a9b79a465af3bd5725892b
# Push it to GitHub
git push --set-upstream origin backport/backport-189-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.xThen, create a pull request where the |
* moved constants to common folder Signed-off-by: Riya Saxena <[email protected]> * fix broken osd functionaltest Repo Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> (cherry picked from commit e597081)
|
@BionIT this PR should be backported after #181. And @amsiglan @riysaxen-amzn could you please help to backport as you have more context than us and you are the authors of the PRs related. and we are afraid we may make an unnecessary backport by accident. |
* Fix broken osd functional test repo (#189) * moved constants to common folder Signed-off-by: Riya Saxena <[email protected]> * fix broken osd functionaltest Repo Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> (cherry picked from commit e597081) * fix merge conflict Signed-off-by: Riya Saxena <[email protected]> * revert configRoutes changes Signed-off-by: Riya Saxena <[email protected]> * revert configRoutes changes Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> Co-authored-by: Hailong Cui <[email protected]>
Description
This PR will fix the broken osd repo functional tests
Issues Resolved
Testing
freshVideo.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.