-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix backport issues for CHANGELOG.md file #4978
Conversation
It works 🙂 |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4978 +/- ##
============================================
- Coverage 70.70% 70.67% -0.04%
- Complexity 57627 57674 +47
============================================
Files 4620 4620
Lines 276210 276210
Branches 40421 40421
============================================
- Hits 195295 195205 -90
- Misses 64555 64763 +208
+ Partials 16360 16242 -118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Unrelated:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes it that backported changes don't appear in CHANGELOG. So the CHANGELOG will be incorrect :(
This is part 1 of 2. I am working on automating CHANGELOG backporting, which is part 2. IMHO this is more reliable, given folks were missing out on changes all together. More behind that rationale here - #4977 (comment) |
@kotwanikunal After this we need to go through commits on 2.x and update CHANGELOG to be correct :( |
Gradle Check (Jenkins) Run Completed with:
|
@dblock Please check - #4936 (comment) |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit 171d141) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
038a207
to
ef78bfe
Compare
Skipping changelog since #5082 is taking care of it. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Backport 171d141 from #4977.