Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecation message for REST API parameter 'master_timeout' to specify the version of removal #2863

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 11, 2022

Description

According to the comments, change the deprecation message of REST API parameter master_timeout:
#2678 (comment)
#2682 (comment)

  • Specify the version (3.0) to remove the deprecated parameter.
  • Change the word promote to support.

Issues Resolved

Related to #2511

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tianli Feng added 2 commits April 11, 2022 14:58
@tlfeng tlfeng requested a review from a team as a code owner April 11, 2022 22:04
@tlfeng tlfeng added v2.0.0 Version 2.0.0 deprecate backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch v3.0.0 Issues and PRs related to version 3.0.0 and removed v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 11, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 90a4273
Log 4383

Reports 4383

@tlfeng tlfeng merged commit ba8657a into opensearch-project:main Apr 11, 2022
@tlfeng tlfeng deleted the change-deprecation-message-master-timeout branch April 11, 2022 22:59
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2022
… specify the version of removal (#2863)

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit ba8657a)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2022
… specify the version of removal (#2863)

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit ba8657a)
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
… specify the version of removal (#2863) (#2864)

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit ba8657a)
tlfeng pushed a commit that referenced this pull request Apr 12, 2022
… specify the version of removal (#2863) (#2865)

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit ba8657a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch deprecate v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants