[Backport] [1.2] [FEATURE] Add OPENSEARCH_JAVA_HOME env to override JAVA_HOME (#2040) #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
❌ Gradle Check failure 9accef3aed2050aac80464a337cf7a3500624177 |
…rch-project#2040) Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
issue-issue-1872.1.2
branch
from
9accef3 to
8c90607
Compare
|
I would think this change doesn't meet the definition of "hotfix" defined in the release policy. Do you have a particular reason for wanting to backport this to the 1.2 branch? |
Thanks @andrross I don't have the compelling reasons for 1.2 (besides matching the original documentation section), no objections to close this backport, @dblock sounds good to you? |
|
Agreed, let's close. Shipping this in 1.3.0 (1.x branch) is good. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Backport of #2040 to 1.2
Issues Resolved
Closes #1872
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.