Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix failing CI's with Failed to load eclipse jdt formatter #17186

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

prudhvigodithi
Copy link
Member

Description

Backport of #17172.

Related Issues

Part of #16516

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Member Author

Adding @mch2 @msfroh
Thanks

Copy link
Contributor

✅ Gradle check result for 476a8e4: SUCCESS

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (2187369) to head (476a8e4).
Report is 4 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17186      +/-   ##
============================================
+ Coverage     71.98%   72.44%   +0.45%     
- Complexity    65987    66379     +392     
============================================
  Files          5341     5341              
  Lines        307114   307114              
  Branches      44824    44824              
============================================
+ Hits         221068   222478    +1410     
+ Misses        67608    66431    -1177     
+ Partials      18438    18205     -233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 476a8e4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 29, 2025

❌ Gradle check result for 476a8e4: FAILURE

Seems to be a flaky test(s) coming from #17005 (@msfroh fyi)

Copy link
Contributor

❌ Gradle check result for 476a8e4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 476a8e4: SUCCESS

@mch2 mch2 merged commit 56b5726 into opensearch-project:2.x Jan 29, 2025
93 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants