Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible design to add new query and field type support for Star Tree #17100

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

expani
Copy link
Contributor

@expani expani commented Jan 23, 2025

Description

This PR introduces constructs to help convert user queries into the equivalent star tree traversal by generating the appropriate DimensionFilter based on the type of query.

DimensionFilterMapper acts as an equivalent mapper for Star Tree supported fields and queries.

StarTreeFilterProvider is responsible for converting the user queries ( represented by QueryBuilder )

I have changed all the older tests to point towards the new classes to ensure that we get coverage for at least numeric term queries.

We have tested term, terms and range queries on numeric and keyword over http_logs for sanity of the code and fixed some tricky bugs on different cases. Thanks to @bharath-techie for help with creating end to end query test with randomness.

I will be adding Unit tests for Range and other new classes that are not covered by existing tests in the coming days.

Most of the TODO left around the code will be picked up in future when supporting Filter Aggregations and Boolean queries. If that's not the case, please comment on the same.

Related Issues

#16537
#16538
#16539

expani added 21 commits January 22, 2025 19:55
Signed-off-by: expani <[email protected]>
Signed-off-by: expani <[email protected]>
Copy link
Contributor

❌ Gradle check result for b85183d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant