-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate includes and excludes from fetchSourceContext to FieldsVisitor #17080
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17080 +/- ##
============================================
- Coverage 72.32% 72.28% -0.05%
+ Complexity 65477 65441 -36
============================================
Files 5309 5309
Lines 304306 304324 +18
Branches 44124 44132 +8
============================================
- Hits 220098 219985 -113
- Misses 66159 66278 +119
- Partials 18049 18061 +12 ☔ View full report in Codecov by Sentry. |
e17d6f9
to
8a7b739
Compare
@jmazanec15 please take a look |
❕ Gradle check result for 8a7b739: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/index/fieldvisitor/FieldsVisitor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/fieldvisitor/FieldsVisitor.java
Outdated
Show resolved
Hide resolved
1584d62
to
2d45546
Compare
❌ Gradle check result for 2d45546: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall structure looks good to me. A couple comments on the test
server/src/test/java/org/opensearch/index/mapper/StoredNumericValuesTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/mapper/StoredNumericValuesTests.java
Show resolved
Hide resolved
2d45546
to
018905d
Compare
❕ Gradle check result for 018905d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
018905d
to
9439534
Compare
❌ Gradle check result for 9439534: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
caeedd9
to
9708a84
Compare
Signed-off-by: Ganesh Ramadurai <[email protected]>
9708a84
to
eaec888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait on @jmazanec15 to take another look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @Gankris96
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17080-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 931c1aadaed0d8eccee0839d74d706fb47dbd4be
# Push it to GitHub
git push --set-upstream origin backport/backport-17080-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Description
The change is to propagate the source includes and source excludes fields that are present in the
FetchSourceContext
.This is as part of the open questions in this RFC opensearch-project/k-NN#2377
Related Issues
PR is part of #2377
as part of the Derived source feature for k-NN.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.