-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Response Status Number in Http Trace Logs. #16978
base: main
Are you sure you want to change the base?
Add Response Status Number in Http Trace Logs. #16978
Conversation
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for 2f87a9b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
known flaky test #14324 |
requestId, | ||
opaqueHeader, | ||
restResponse.status(), | ||
restResponse.status().getStatus(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems redundant? I think every RestStatus can be mapped to a unique integer code. Why do we need to also write that integer into this log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah on high level it looks redundant, but there can be use cases where if user wants to configure and trigger an alarm if they see very high 5xx requests in logs. Without having the Response's integer code in log it would be very hard to add filter for RestStatus from 500 -599 as each will have different names. Using filter on Integer codes will be easier as to filter all 500 -599 responses we can just use 5xx.
Description
This PR adds response status number like
200
forOK
response in the Http Trace Logs.Related Issues
Current Http Response Logs when Trace is enabled:
PR changes Http Response Logs when Trace is enabled to:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.