Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Indexing] Enhance RestAction with request / response streaming support #13772

Merged
merged 2 commits into from
Jun 10, 2024

Address code review comments

aea22d9
Select commit
Loading
Failed to load commit list.
Merged

[Streaming Indexing] Enhance RestAction with request / response streaming support #13772

Address code review comments
aea22d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jun 10, 2024 in 0s

45.90% of diff hit (target 71.42%)

View this Pull Request on Codecov

45.90% of diff hit (target 71.42%)

Annotations

Check warning on line 35 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpChunk.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpChunk.java#L35 

Added line #L35 was not covered by tests

Check warning on line 47 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpChunk.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4HttpChunk.java#L47 

Added line #L47 was not covered by tests

Check warning on line 53 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L53 

Added line #L53 was not covered by tests

Check warning on line 59 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L58-L59 

Added lines #L58 - L59 were not covered by tests

Check warning on line 64 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L63-L64 

Added lines #L63 - L64 were not covered by tests

Check warning on line 74 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L73-L74 

Added lines #L73 - L74 were not covered by tests

Check warning on line 80 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L78-L80 

Added lines #L78 - L80 were not covered by tests

Check warning on line 84 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L84 

Added line #L84 was not covered by tests

Check warning on line 89 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L89 

Added line #L89 was not covered by tests

Check warning on line 96 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L96 

Added line #L96 was not covered by tests

Check warning on line 99 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L99 

Added line #L99 was not covered by tests

Check warning on line 102 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L101-L102 

Added lines #L101 - L102 were not covered by tests

Check warning on line 107 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L107 

Added line #L107 was not covered by tests

Check warning on line 122 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L121-L122 

Added lines #L121 - L122 were not covered by tests

Check warning on line 126 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingHttpChannel.java#L125-L126 

Added lines #L125 - L126 were not covered by tests

Check warning on line 35 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java#L35 

Added line #L35 was not covered by tests

Check warning on line 37 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java#L37 

Added line #L37 was not covered by tests

Check warning on line 39 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingRequestConsumer.java#L39 

Added line #L39 was not covered by tests

Check warning on line 37 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingResponseProducer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingResponseProducer.java#L35-L37 

Added lines #L35 - L37 were not covered by tests

Check warning on line 52 in plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingResponseProducer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/transport-reactor-netty4/src/main/java/org/opensearch/http/reactor/netty4/ReactorNetty4StreamingResponseProducer.java#L52 

Added line #L52 was not covered by tests

Check warning on line 62 in server/src/main/java/org/opensearch/common/xcontent/support/XContentHttpChunk.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/common/xcontent/support/XContentHttpChunk.java#L62 

Added line #L62 was not covered by tests

Check warning on line 479 in server/src/main/java/org/opensearch/http/AbstractHttpServerTransport.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/http/AbstractHttpServerTransport.java#L479 

Added line #L479 was not covered by tests

Check warning on line 490 in server/src/main/java/org/opensearch/http/AbstractHttpServerTransport.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/http/AbstractHttpServerTransport.java#L490 

Added line #L490 was not covered by tests

Check warning on line 61 in server/src/main/java/org/opensearch/http/DefaultStreamingRestChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/http/DefaultStreamingRestChannel.java#L60-L61 

Added lines #L60 - L61 were not covered by tests

Check warning on line 85 in server/src/main/java/org/opensearch/http/DefaultStreamingRestChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/http/DefaultStreamingRestChannel.java#L85 

Added line #L85 was not covered by tests
View more details on Codecov