-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update assertion in _metric_chart.js #9391
base: main
Are you sure you want to change the base?
fix: update assertion in _metric_chart.js #9391
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9391 +/- ##
=======================================
Coverage 61.71% 61.72%
=======================================
Files 3817 3817
Lines 91860 91860
Branches 14551 14551
=======================================
+ Hits 56695 56697 +2
+ Misses 31508 31507 -1
+ Partials 3657 3656 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
e078fb6
to
e06d5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking this
Description
OS bump t-digest to 3.3 and it introduces an inconsistency in test
_metric_chart.js
. This PR is to make the assertion more flexible so that it can cover both the case of 2.x OS and 3.x OS.Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration