Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] chore: Update query editor loading UI #9344

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

Maosaic
Copy link
Contributor

@Maosaic Maosaic commented Feb 6, 2025

Description

Improve query editor loading UX:

  1. Spinner in editor footer will show immediately when query start. (time elapsed text will show 3s later)
  2. Added a progress bar in query editor
  3. Update loading text font

Issues Resolved

Screenshot

Screen.Recording.2025-02-06.at.10.54.49.AM.mp4
Screen.Recording.2025-02-11.at.10.26.18.AM.mp4

Testing the changes

Changelog

  • chore: Update query editor loading UI

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.71%. Comparing base (8cc5f84) to head (cf089dd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...query_string/language_service/lib/query_result.tsx 50.00% 0 Missing and 1 partial ⚠️
...c/ui/query_editor/editors/default_editor/index.tsx 0.00% 1 Missing ⚠️
...ins/data/public/ui/query_editor/editors/shared.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9344   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91841    91844    +3     
  Branches    14545    14548    +3     
=======================================
+ Hits        56677    56680    +3     
  Misses      31508    31508           
  Partials     3656     3656           
Flag Coverage Δ
Linux_1 28.98% <0.00%> (-0.01%) ⬇️
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <25.00%> (?)
Linux_4 28.90% <0.00%> (-0.01%) ⬇️
Windows_1 29.00% <0.00%> (-0.01%) ⬇️
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <25.00%> (+<0.01%) ⬆️
Windows_4 28.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla added backport 2.x discover for discover reinvent v2.20.0 labels Feb 7, 2025
sejli
sejli previously approved these changes Feb 11, 2025
Maosaic pushed a commit to Maosaic/OpenSearch-Dashboards that referenced this pull request Feb 11, 2025
abbyhu2000
abbyhu2000 previously approved these changes Feb 13, 2025
Signed-off-by: Joey Liu <[email protected]>
@Maosaic Maosaic dismissed stale reviews from abbyhu2000 and sejli via cf089dd February 13, 2025 23:43
@abbyhu2000 abbyhu2000 merged commit 198482b into opensearch-project:main Feb 14, 2025
68 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 14, 2025
* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 198482b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Maosaic Maosaic deleted the loading branch February 14, 2025 05:47
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
kavilla pushed a commit that referenced this pull request Feb 14, 2025
* [Discover] chore: Update query editor loading UI

* Move progress bar position



* Update loading text font



* update unit test snapshot



* Update single line query editor



* Changeset file for PR #9344 created/updated

* pull doc update



---------



(cherry picked from commit 198482b)

Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh added a commit that referenced this pull request Feb 14, 2025
* add max recent queries tests

Signed-off-by: Federico Silva <[email protected]>

* refactor callback function

Signed-off-by: Federico Silva <[email protected]>

* add testid-42 tests

Signed-off-by: Federico Silva <[email protected]>

* add comments

Signed-off-by: Federico Silva <[email protected]>

* add spec to package.json

Signed-off-by: Federico Silva <[email protected]>

* fix testconfig fn name

Signed-off-by: Federico Silva <[email protected]>

* fix clipboard flakiness

Signed-off-by: Federico Silva <[email protected]>

* refactor test preparation

Signed-off-by: Federico Silva <[email protected]>

* fix package.json, yarn.locl and cypress.config.ts

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR #9307 created/updated

Signed-off-by: Federico Silva <[email protected]>

* remove element.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Refactor based on #9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* comment out tests with dependencies

Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (#9384)

Issue Resolved:
#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Anan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
ananzh added a commit that referenced this pull request Feb 17, 2025
* Update actions/cache from v1 to v4 to address deprecation warning (#9366)

* build: Update actions/cache from v1 to v4 to address deprecation warning

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9366 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* Handle invalid geospatial request in region map (#8759)

Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* Update DEVELOPER_GUIDE.md (#9368)

When building the OpenSearch Dashboards artifact for Linux, the build may fail on certain distributions. This issue stems from the recent upgrade from node-sass to dart-sass. The new process uses an embeddable module from dart-sass to process Sass files, which relies on a platform-specific compiler. On Linux, this module depends on glibc. However, some distributions—like Alpine Linux—use musl libc instead, which is incompatible with this module. I'm updating the DEVELOPER_GUIDE documentation to help other developers choose the appropriate distro for Docker images and avoid the pitfalls I encountered.
See the issue I created in Github explaining this reasoning: #9329
Also the forum where I posted the kind of error you see when building with a Linux Distribution that is incompatible with glibc: https://forum.opensearch.org/t/docker-a-error-error-worker-exitted-unexpectedly-with-code-1-last-message-bundleid-embeddable-type-running/23214

Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* create histogram tests

Signed-off-by: Federico Silva <[email protected]>

* update callback, refactor tests

Signed-off-by: Federico Silva <[email protected]>

* fix hooks

Signed-off-by: Federico Silva <[email protected]>

* add comments to code, refactor preconditions

Signed-off-by: Federico Silva <[email protected]>

* update hooks to beforeEach and afterEach for CI/CD

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR #9290 created/updated

Signed-off-by: Federico Silva <[email protected]>

* add todos

Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

* remove elements.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Refactor based on #9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* skip permutation for SQL

Signed-off-by: Federico Silva <[email protected]>

* add todo

Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (#9384)

Issue Resolved:
#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Junqiu Lei <[email protected]>
Co-authored-by: Luis Beltrán <[email protected]>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
…9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
* add max recent queries tests

Signed-off-by: Federico Silva <[email protected]>

* refactor callback function

Signed-off-by: Federico Silva <[email protected]>

* add testid-42 tests

Signed-off-by: Federico Silva <[email protected]>

* add comments

Signed-off-by: Federico Silva <[email protected]>

* add spec to package.json

Signed-off-by: Federico Silva <[email protected]>

* fix testconfig fn name

Signed-off-by: Federico Silva <[email protected]>

* fix clipboard flakiness

Signed-off-by: Federico Silva <[email protected]>

* refactor test preparation

Signed-off-by: Federico Silva <[email protected]>

* fix package.json, yarn.locl and cypress.config.ts

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR opensearch-project#9307 created/updated

Signed-off-by: Federico Silva <[email protected]>

* remove element.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (opensearch-project#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (opensearch-project#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Refactor based on opensearch-project#9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* comment out tests with dependencies

Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (opensearch-project#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (opensearch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (opensearch-project#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (opensearch-project#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR opensearch-project#9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (opensearch-project#9384)

Issue Resolved:
opensearch-project#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Anan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
* Update actions/cache from v1 to v4 to address deprecation warning (opensearch-project#9366)

* build: Update actions/cache from v1 to v4 to address deprecation warning

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9366 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* Handle invalid geospatial request in region map (opensearch-project#8759)

Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* Update DEVELOPER_GUIDE.md (opensearch-project#9368)

When building the OpenSearch Dashboards artifact for Linux, the build may fail on certain distributions. This issue stems from the recent upgrade from node-sass to dart-sass. The new process uses an embeddable module from dart-sass to process Sass files, which relies on a platform-specific compiler. On Linux, this module depends on glibc. However, some distributions—like Alpine Linux—use musl libc instead, which is incompatible with this module. I'm updating the DEVELOPER_GUIDE documentation to help other developers choose the appropriate distro for Docker images and avoid the pitfalls I encountered.
See the issue I created in Github explaining this reasoning: opensearch-project#9329
Also the forum where I posted the kind of error you see when building with a Linux Distribution that is incompatible with glibc: https://forum.opensearch.org/t/docker-a-error-error-worker-exitted-unexpectedly-with-code-1-last-message-bundleid-embeddable-type-running/23214

Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* create histogram tests

Signed-off-by: Federico Silva <[email protected]>

* update callback, refactor tests

Signed-off-by: Federico Silva <[email protected]>

* fix hooks

Signed-off-by: Federico Silva <[email protected]>

* add comments to code, refactor preconditions

Signed-off-by: Federico Silva <[email protected]>

* update hooks to beforeEach and afterEach for CI/CD

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR opensearch-project#9290 created/updated

Signed-off-by: Federico Silva <[email protected]>

* add todos

Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

* remove elements.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (opensearch-project#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (opensearch-project#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Refactor based on opensearch-project#9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (opensearch-project#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* skip permutation for SQL

Signed-off-by: Federico Silva <[email protected]>

* add todo

Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (opensearch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (opensearch-project#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (opensearch-project#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR opensearch-project#9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (opensearch-project#9384)

Issue Resolved:
opensearch-project#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Junqiu Lei <[email protected]>
Co-authored-by: Luis Beltrán <[email protected]>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants