Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTID-64,80,UI] Add cypress test for autocomplete feature #9322

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 3, 2025

Description

Add tests related to autocomplete.

Issues Resolved

This will close all the issues listed here:
https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Screenshot

NA

Changelog

-test: [TESTID-64] Add cypress test for auto query updates when switch dataset

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (8cc5f84) to head (6a8c9c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9322   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91841    91841           
  Branches    14545    14545           
=======================================
+ Hits        56677    56679    +2     
+ Misses      31508    31507    -1     
+ Partials     3656     3655    -1     
Flag Coverage Δ
Linux_1 28.98% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (?)
Linux_4 28.90% <ø> (ø)
Windows_1 29.00% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.19% <ø> (-0.01%) ⬇️
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added the v2.20.0 label Feb 3, 2025
url: PATHS.SECONDARY_ENGINE,
authType: 'no_auth',
});
cy.deleteAllWorkspaces();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleteWorkSpaceByName()

(config) => {
describe(`${config.testName}`, () => {
beforeEach(() => {
if (config.datasetType === 'INDEX_PATTERN') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: config.dataType === DataTypes.IndexPattern.name (or something like that)

});
});

it('should show and select suggestions progressively', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nitpick: arrow function

url: PATHS.SECONDARY_ENGINE,
authType: 'no_auth',
});
cy.deleteAllWorkspaces();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleteWorkspaceByName

}).forEach((config) => {
describe(`${config.testName}`, () => {
beforeEach(() => {
if (config.datasetType === 'INDEX_PATTERN') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: DataTypes.IndexPattern.name

url: PATHS.SECONDARY_ENGINE,
authType: 'no_auth',
});
cy.deleteAllWorkspaces();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleteWorkspaceByName

@ananzh ananzh force-pushed the TESTID-64-1 branch 3 times, most recently from b4264e2 to e4e2119 Compare February 12, 2025 19:58
opensearch-changeset-bot bot added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 12, 2025
@ananzh ananzh force-pushed the TESTID-64-1 branch 3 times, most recently from ec36302 to 21b9d0f Compare February 13, 2025 15:27
@@ -3,7 +3,80 @@
* SPDX-License-Identifier: Apache-2.0
*/

Cypress.Commands.add('setQueryEditor', (value, opts = {}, submit = true) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opts is needed for the ignoreSpecialSequence or whatever it was called

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add

.type('{backspace}')
.type(value, opts);
clearMonacoEditor().then(() => {
return cy.get('.inputarea').should('be.visible').wait(200).type(value, { force: true });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass in the option here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member

@sejli sejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but LGTM

}

cy.waitForLoader(true);
cy.wait(2000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we are using cy.wait() for some time after we use the cy.waitForLoader() function in a few cases. Is there a reason why we need the extra wait?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just see some flakiness when test 3 times in a row. Put a bit more time can ensure they success 3 times.

.wait(200); // Wait for focus to take effect
};

const clearMonacoEditor = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that usually works for me in Cypress is to use .type("{selectall}{backspace}{selectall}{backspace}") to clear inputs, not sure if it would work in this case though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. so far this is the most stable way to avoid flakiness.

@abbyhu2000 abbyhu2000 merged commit 3c6c806 into opensearch-project:main Feb 14, 2025
70 of 71 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9322-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3c6c806d55b837bdb16295b6066a312c5d9a39db
# Push it to GitHub
git push --set-upstream origin backport/backport-9322-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9322-to-2.x.

silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…ch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…ch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…ch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Feb 14, 2025
…ch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>
ananzh added a commit that referenced this pull request Feb 14, 2025
* add max recent queries tests

Signed-off-by: Federico Silva <[email protected]>

* refactor callback function

Signed-off-by: Federico Silva <[email protected]>

* add testid-42 tests

Signed-off-by: Federico Silva <[email protected]>

* add comments

Signed-off-by: Federico Silva <[email protected]>

* add spec to package.json

Signed-off-by: Federico Silva <[email protected]>

* fix testconfig fn name

Signed-off-by: Federico Silva <[email protected]>

* fix clipboard flakiness

Signed-off-by: Federico Silva <[email protected]>

* refactor test preparation

Signed-off-by: Federico Silva <[email protected]>

* fix package.json, yarn.locl and cypress.config.ts

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR #9307 created/updated

Signed-off-by: Federico Silva <[email protected]>

* remove element.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Refactor based on #9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* comment out tests with dependencies

Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (#9384)

Issue Resolved:
#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Anan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
ananzh added a commit that referenced this pull request Feb 17, 2025
* Update actions/cache from v1 to v4 to address deprecation warning (#9366)

* build: Update actions/cache from v1 to v4 to address deprecation warning

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9366 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* Handle invalid geospatial request in region map (#8759)

Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* Update DEVELOPER_GUIDE.md (#9368)

When building the OpenSearch Dashboards artifact for Linux, the build may fail on certain distributions. This issue stems from the recent upgrade from node-sass to dart-sass. The new process uses an embeddable module from dart-sass to process Sass files, which relies on a platform-specific compiler. On Linux, this module depends on glibc. However, some distributions—like Alpine Linux—use musl libc instead, which is incompatible with this module. I'm updating the DEVELOPER_GUIDE documentation to help other developers choose the appropriate distro for Docker images and avoid the pitfalls I encountered.
See the issue I created in Github explaining this reasoning: #9329
Also the forum where I posted the kind of error you see when building with a Linux Distribution that is incompatible with glibc: https://forum.opensearch.org/t/docker-a-error-error-worker-exitted-unexpectedly-with-code-1-last-message-bundleid-embeddable-type-running/23214

Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* create histogram tests

Signed-off-by: Federico Silva <[email protected]>

* update callback, refactor tests

Signed-off-by: Federico Silva <[email protected]>

* fix hooks

Signed-off-by: Federico Silva <[email protected]>

* add comments to code, refactor preconditions

Signed-off-by: Federico Silva <[email protected]>

* update hooks to beforeEach and afterEach for CI/CD

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR #9290 created/updated

Signed-off-by: Federico Silva <[email protected]>

* add todos

Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

* remove elements.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR #9331 created/updated

* Refactor based on #9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* skip permutation for SQL

Signed-off-by: Federico Silva <[email protected]>

* add todo

Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR #9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR #9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (#9384)

Issue Resolved:
#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Junqiu Lei <[email protected]>
Co-authored-by: Luis Beltrán <[email protected]>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
…ch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
* add max recent queries tests

Signed-off-by: Federico Silva <[email protected]>

* refactor callback function

Signed-off-by: Federico Silva <[email protected]>

* add testid-42 tests

Signed-off-by: Federico Silva <[email protected]>

* add comments

Signed-off-by: Federico Silva <[email protected]>

* add spec to package.json

Signed-off-by: Federico Silva <[email protected]>

* fix testconfig fn name

Signed-off-by: Federico Silva <[email protected]>

* fix clipboard flakiness

Signed-off-by: Federico Silva <[email protected]>

* refactor test preparation

Signed-off-by: Federico Silva <[email protected]>

* fix package.json, yarn.locl and cypress.config.ts

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR opensearch-project#9307 created/updated

Signed-off-by: Federico Silva <[email protected]>

* remove element.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (opensearch-project#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (opensearch-project#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Refactor based on opensearch-project#9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* comment out tests with dependencies

Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (opensearch-project#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (opensearch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (opensearch-project#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (opensearch-project#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR opensearch-project#9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (opensearch-project#9384)

Issue Resolved:
opensearch-project#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Anan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
* Update actions/cache from v1 to v4 to address deprecation warning (opensearch-project#9366)

* build: Update actions/cache from v1 to v4 to address deprecation warning

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9366 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* Handle invalid geospatial request in region map (opensearch-project#8759)

Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* Update DEVELOPER_GUIDE.md (opensearch-project#9368)

When building the OpenSearch Dashboards artifact for Linux, the build may fail on certain distributions. This issue stems from the recent upgrade from node-sass to dart-sass. The new process uses an embeddable module from dart-sass to process Sass files, which relies on a platform-specific compiler. On Linux, this module depends on glibc. However, some distributions—like Alpine Linux—use musl libc instead, which is incompatible with this module. I'm updating the DEVELOPER_GUIDE documentation to help other developers choose the appropriate distro for Docker images and avoid the pitfalls I encountered.
See the issue I created in Github explaining this reasoning: opensearch-project#9329
Also the forum where I posted the kind of error you see when building with a Linux Distribution that is incompatible with glibc: https://forum.opensearch.org/t/docker-a-error-error-worker-exitted-unexpectedly-with-code-1-last-message-bundleid-embeddable-type-running/23214

Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* create histogram tests

Signed-off-by: Federico Silva <[email protected]>

* update callback, refactor tests

Signed-off-by: Federico Silva <[email protected]>

* fix hooks

Signed-off-by: Federico Silva <[email protected]>

* add comments to code, refactor preconditions

Signed-off-by: Federico Silva <[email protected]>

* update hooks to beforeEach and afterEach for CI/CD

Signed-off-by: Federico Silva <[email protected]>

* Changeset file for PR opensearch-project#9290 created/updated

Signed-off-by: Federico Silva <[email protected]>

* add todos

Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

* remove elements.js references

Signed-off-by: Federico Silva <[email protected]>

* [Documentation] Add alternative Docker Development Environment Setup documentation. (opensearch-project#9362)

* Add alternative Docker Development Environment Setup.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9362 created/updated

* Use relative link

Signed-off-by: Argus Li <[email protected]>

* Address Suchit's comments.

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-77] Index Patterns Caching functionality for Discover (opensearch-project#9331)

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Create caching test.

Signed-off-by: Argus Li <[email protected]>

* Changeset file for PR opensearch-project#9331 created/updated

* Refactor based on opensearch-project#9319

Signed-off-by: Argus Li <[email protected]>

* Update package.json

Signed-off-by: Suchit Sahoo <[email protected]>

* Remove element.js

Signed-off-by: Argus Li <[email protected]>

---------

Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav (opensearch-project#9316)

* [Discover] fix: Clean up sync URL subscription in Discover plugin topNav

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9316 created/updated

* Update unit test

Signed-off-by: Joey Liu <[email protected]>

* Revert save modal change

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* skip permutation for SQL

Signed-off-by: Federico Silva <[email protected]>

* add todo

Signed-off-by: Federico Silva <[email protected]>

* [TESTID-64,80,UI] Add cypress test for autocomplete feature (opensearch-project#9322)

* [TESTID-64,80,UI] Add cypress test for autocomplete feature

Add tests related to autocomplete. This will close all the issues listed here:

https://github.com/opensearch-project/OpenSearch-Dashboards/issues/assigned/ananzh?q=is%3Aissue%20assignee%3Aananzh%20label%3A%22discover%20autocomplete%22%20

Signed-off-by: Anan <[email protected]>

* Changeset file for PR opensearch-project#9322 created/updated

---------

Signed-off-by: Anan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [Discover] chore: Update query editor loading UI (opensearch-project#9344)

* [Discover] chore: Update query editor loading UI

* Move progress bar position

Signed-off-by: Joey Liu <[email protected]>

* Update loading text font

Signed-off-by: Joey Liu <[email protected]>

* update unit test snapshot

Signed-off-by: Joey Liu <[email protected]>

* Update single line query editor

Signed-off-by: Joey Liu <[email protected]>

* Changeset file for PR opensearch-project#9344 created/updated

* pull doc update

Signed-off-by: Joey Liu <[email protected]>

---------

Signed-off-by: Joey Liu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* feat(vis_type_vega): support reading time field (opensearch-project#9152)

* feat(vis_type_vega): support reading time field

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR opensearch-project#9152 created/updated

* fix time format to use moment.utc

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Federico Silva <[email protected]>

* [TESTID-17] Add tests for query testing and advanced settings (opensearch-project#9384)

Issue Resolved:
opensearch-project#8934

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>

* add to package.json

Signed-off-by: Federico Silva <[email protected]>

---------

Signed-off-by: Anan <[email protected]>
Signed-off-by: Federico Silva <[email protected]>
Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Luis Beltrán <[email protected]>
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: Joey Liu <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Junqiu Lei <[email protected]>
Co-authored-by: Luis Beltrán <[email protected]>
Co-authored-by: Argus Li <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Joey Liu <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative failed backport v2.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants