Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Builder] Rename wizard to visBuilder in class name, type name and function name #2748

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 74fd39f from #2639.

#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 74fd39f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 2, 2022 23:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #2748 (c2c37d7) into 2.x (ff12ae3) will increase coverage by 0.00%.
The diff coverage is 35.96%.

@@           Coverage Diff           @@
##              2.x    #2748   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files        3209     3210    +1     
  Lines       61263    61266    +3     
  Branches     9358     9360    +2     
=======================================
+ Hits        40888    40895    +7     
+ Misses      18133    18126    -7     
- Partials     2242     2245    +3     
Impacted Files Coverage Δ
src/core/public/doc_links/doc_links_service.ts 100.00% <ø> (ø)
.../saved_objects/migrations/core/opensearch_index.ts 93.50% <ø> (ø)
...s_management/public/lib/get_saved_object_counts.ts 0.00% <ø> (ø)
.../plugins/saved_objects_management/public/plugin.ts 63.15% <ø> (ø)
...ins/saved_objects_management/server/routes/find.ts 9.52% <ø> (+2.62%) ⬆️
...d_objects_management/server/routes/scroll_count.ts 6.25% <0.00%> (+0.69%) ⬆️
src/plugins/vis_builder/common/index.ts 100.00% <ø> (ø)
...blic/application/components/data_source_select.tsx 9.09% <ø> (ø)
...c/application/components/data_tab/config_panel.tsx 0.00% <ø> (ø)
...public/application/components/data_tab/dropbox.tsx 7.69% <ø> (ø)
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Nov 3, 2022
@AMoo-Miki AMoo-Miki merged commit b8d0390 into 2.x Nov 3, 2022
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2748-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8d03904267eeece10d6174a7480ccc69ca6ab70
# Push it to GitHub
git push --set-upstream origin backport/backport-2748-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-2748-to-2.4.

@kavilla kavilla deleted the backport-2639-to-2.x branch November 23, 2022 09:09
@joshuarrrr joshuarrrr added the v2.4.0 'Issues and PRs related to version v2.4.0' label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants