[Backport 2.x] Allow node patch versions to be higher on runtime #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
This adjusts the runtime node version check to only compare major and
minor version requirements. Systems that don't use the bundled NodeJS
might update their node due to security patches, which would currently
break OpenSearch Dashboards unnecessarily.
```shell
% grep 14.18 ../../package.json
"node": "14.18.2",
% nvm use 12
Now using node v12.22.8 (npm v6.14.15)
% node node_version_validator.js
OpenSearch Dashboards does not support the current Node.js version v12.22.8. Please use Node.js ~v14.18.
% nvm use 14
Now using node v14.18.3 (npm v6.14.15)
% node node_version_validator.js
%
```
* Mention Node.js version Dashboards was built with in runtime check error
* Use template literals in node version validator
* Add additional node validator tests, cleanup
* Don't allow node patch versions to be lower on runtime
Signed-off-by: Justin Kromlinger <[email protected]>
(cherry picked from commit 0a24652)
tmarkley
approved these changes
Jun 8, 2022
kavilla
approved these changes
Jun 8, 2022
cliu123
pushed a commit
to cliu123/OpenSearch-Dashboards
that referenced
this pull request
Jun 30, 2022
…#1189) (opensearch-project#1677) This adjusts the runtime node version check to only compare major and minor version requirements. Systems that don't use the bundled NodeJS might update their node due to security patches, which would currently break OpenSearch Dashboards unnecessarily. ```shell % grep 14.18 ../../package.json "node": "14.18.2", % nvm use 12 Now using node v12.22.8 (npm v6.14.15) % node node_version_validator.js OpenSearch Dashboards does not support the current Node.js version v12.22.8. Please use Node.js ~v14.18. % nvm use 14 Now using node v14.18.3 (npm v6.14.15) % node node_version_validator.js % ``` * Mention Node.js version Dashboards was built with in runtime check error * Use template literals in node version validator * Add additional node validator tests, cleanup * Don't allow node patch versions to be lower on runtime Signed-off-by: Justin Kromlinger <[email protected]> (cherry picked from commit 0a24652)
cliu123
pushed a commit
to cliu123/OpenSearch-Dashboards
that referenced
this pull request
Jun 30, 2022
…#1189) (opensearch-project#1677) This adjusts the runtime node version check to only compare major and minor version requirements. Systems that don't use the bundled NodeJS might update their node due to security patches, which would currently break OpenSearch Dashboards unnecessarily. ```shell % grep 14.18 ../../package.json "node": "14.18.2", % nvm use 12 Now using node v12.22.8 (npm v6.14.15) % node node_version_validator.js OpenSearch Dashboards does not support the current Node.js version v12.22.8. Please use Node.js ~v14.18. % nvm use 14 Now using node v14.18.3 (npm v6.14.15) % node node_version_validator.js % ``` * Mention Node.js version Dashboards was built with in runtime check error * Use template literals in node version validator * Add additional node validator tests, cleanup * Don't allow node patch versions to be lower on runtime Signed-off-by: Justin Kromlinger <[email protected]> (cherry picked from commit 0a24652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0a24652 from #1189