Add proper e2e + bugfix

Signed-off-by: sitbubu <[email protected]>

src/plugins/discover/public/mocks.ts

@@ -40,6 +40,9 @@ const createSetupContract = (): Setup => {
     docViews: {
       addDocView: jest.fn(),
     },
+    docViewsLinks: {
+      addDocViewLink: jest.fn(),
+    },
   };
   return setupContract;
 };

src/plugins/discover/public/plugin.ts

@@ -370,6 +370,9 @@ export class DiscoverPlugin
       docViews: {
         addDocView: this.docViewsRegistry.addDocView.bind(this.docViewsRegistry),
       },
+      docViewsLinks: {
+        addDocViewLink: this.docViewsLinksRegistry.addDocViewLink.bind(this.docViewsLinksRegistry),
+      },
     };
   }
 

test/plugin_functional/config.ts

@@ -50,6 +50,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
       require.resolve('./test_suites/core_plugins'),
       require.resolve('./test_suites/management'),
       require.resolve('./test_suites/doc_views'),
+      require.resolve('./test_suites/doc_views_links'),
       require.resolve('./test_suites/application_links'),
       require.resolve('./test_suites/data_plugin'),
     ],

test/plugin_functional/plugins/doc_views_links_plugin/public/plugin.tsx

@@ -23,13 +23,13 @@ function MyHit(props: { index: string }) {
 export class DocViewsLinksPlugin implements Plugin<void, void> {
   public setup(core: CoreSetup, { discover }: { discover: DiscoverSetup }) {
     discover.docViewsLinks.addDocViewLink({
-      href: 'http://locationHref',
+      href: 'http://some-url/',
       order: 1,
       label: 'href doc view link',
     });
 
     discover.docViewsLinks.addDocViewLink({
-      generateUrlFn: (props) => 'http://locationHref',
+      generateUrlFn: (props) => 'http://some-url/',
       order: 2,
       label: 'generateUrlFn doc view link',
     });

test/plugin_functional/test_suites/doc_views_links/doc_views_links.ts

@@ -0,0 +1,40 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import expect from '@osd/expect';
+import { PluginFunctionalProviderContext } from '../../services';
+
+export default function ({ getService, getPageObjects }: PluginFunctionalProviderContext) {
+  const testSubjects = getService('testSubjects');
+  const find = getService('find');
+  const browser = getService('browser');
+  const PageObjects = getPageObjects(['common', 'discover', 'timePicker']);
+
+  describe('custom doc views links', function () {
+    beforeEach(async () => {
+      await PageObjects.common.navigateToApp('discover');
+      await PageObjects.timePicker.setDefaultAbsoluteRange();
+      await testSubjects.click('docTableExpandToggleColumn');
+    });
+
+    it('should show href doc views link', async () => {
+      const hrefLink = await find.byLinkText('href doc view link');
+      await find.byLinkText('generateUrlFn doc view link');
+      expect(await hrefLink.isDisplayed()).to.be(true);
+    });
+
+    it('should render href doc view link', async () => {
+      const hrefLink = await find.byLinkText('href doc view link');
+      await hrefLink.click();
+      expect(await browser.getCurrentUrl()).to.eql('http://some-url/');
+    });
+
+    it('should render react doc view', async () => {
+      const generateUrlFnLink = await find.byLinkText('generateUrlFn doc view link');
+      await generateUrlFnLink.click();
+      expect(await browser.getCurrentUrl()).to.eql('http://some-url/');
+    });
+  });
+}

test/plugin_functional/test_suites/doc_views_links/index.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import { PluginFunctionalProviderContext } from '../../services';
+
+export default function ({ getService, loadTestFile }: PluginFunctionalProviderContext) {
+  const opensearchArchiver = getService('opensearchArchiver');
+
+  describe('doc views links', function () {
+    before(async () => {
+      await opensearchArchiver.loadIfNeeded('../functional/fixtures/opensearch_archiver/discover');
+    });
+
+    loadTestFile(require.resolve('./doc_views_links'));
+  });
+}