Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duckdb blocking #179

Closed
wants to merge 25 commits into from
Closed

duckdb blocking #179

wants to merge 25 commits into from

Conversation

jbothma
Copy link
Contributor

@jbothma jbothma commented Nov 1, 2024

No description provided.

pudo
pudo reviewed Nov 3, 2024
View reviewed changes
nomenklatura/index/duckdb_index.py Outdated
query = """
SELECT field, token, id, frequency
FROM frequencies
ORDER by field, token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird, but: is there a world where we want to do ORDER BY frequency DESC OFFSET 1000 (or OFFSET 1%) here to basically take out stopword tokens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but are you happy for me to park the idea for a while and come back to it in the future? It feels lik a basic xref improvment and some other things are higher prio and this might need some experimentation

@jbothma jbothma closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudo pudo pudo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbothma @pudo