Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move footer buttons to content area #1724

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Move footer buttons to content area #1724

merged 4 commits into from
Feb 14, 2025

Conversation

tomodwyer
Copy link
Member

@tomodwyer tomodwyer commented Feb 12, 2025

Closes #1513

URLs starting with the path names listed in the buttonPaths array of extra.js have buttons moved from the footer, to the main content area.

Before

02
04

After

03
01

This is only applies to the specified URLs listed in the `extra.js`
file
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2025

Deploying opensafely-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6474131
Status: ✅  Deploy successful!
Preview URL: https://2ad1a82a.opensafely-docs.pages.dev
Branch Preview URL: https://prev-next-buttons.opensafely-docs.pages.dev

View logs

Copy link
Contributor

@mikerkelly mikerkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, thanks.

I only wondered a little bit why it's scoped to the two tutorials. I can see that's probably where it's most useful as they follow a linear progression and when you get to the bottom you want it to be intuitive which UI element to interact with next, but there are other pages in section groups that have the footer-style Previous/Next. Could/should we apply this across everything?

Original Slack thread mentions a page that I think has moved here for example.

docs/js/extra.js Outdated Show resolved Hide resolved
Co-authored-by: Mike Kelly <[email protected]>
@tomodwyer
Copy link
Member Author

@mikerkelly those two sections were the ones I was sure needed this functionality. I will add a commit now to add that extra section too.

My hope was that as we identified sections, or changed URLs, people would update the list of URLs.

@tomodwyer tomodwyer merged commit 919a417 into main Feb 14, 2025
2 checks passed
@tomodwyer tomodwyer deleted the prev-next-buttons branch February 14, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previous and Next links
3 participants