-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move footer buttons to content area #1724
Conversation
This is only applies to the specified URLs listed in the `extra.js` file
Deploying opensafely-docs with
|
Latest commit: |
6474131
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2ad1a82a.opensafely-docs.pages.dev |
Branch Preview URL: | https://prev-next-buttons.opensafely-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, thanks.
I only wondered a little bit why it's scoped to the two tutorials. I can see that's probably where it's most useful as they follow a linear progression and when you get to the bottom you want it to be intuitive which UI element to interact with next, but there are other pages in section groups that have the footer-style Previous/Next. Could/should we apply this across everything?
Original Slack thread mentions a page that I think has moved here for example.
Co-authored-by: Mike Kelly <[email protected]>
@mikerkelly those two sections were the ones I was sure needed this functionality. I will add a commit now to add that extra section too. My hope was that as we identified sections, or changed URLs, people would update the list of URLs. |
Closes #1513
URLs starting with the path names listed in the
buttonPaths
array ofextra.js
have buttons moved from the footer, to the main content area.Before
After