Upgrade requests-cache to v1 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to upgrade requests-cache, and maybe consider a new release when other things are upgraded, because it's blocking opensafely-core/reports#551. (This isn't urgent, though.) |
|
This needs a rebase following #118, which is needed to fix the CI. |
This was referenced Feb 8, 2024
StevenMaude
force-pushed
the
steve/requests-cache-v1
branch
2 times, most recently
from
cac7770 to
e4f2fad
Compare
iaindillingham
approved these changes
Feb 14, 2024
https://github.com/requests-cache/requests-cache/blob/main/HISTORY.md#100-2023-03-01 > Update `BaseCache.urls` into a method that takes optional filter params, > and returns sorted unique URLs
This is to upgrade the platforms dirs transitive dependency, which blocks upgrading requests-cache, due to conflicting version requirements.
This also upgrades other transitive dependencies.
StevenMaude
force-pushed
the
steve/requests-cache-v1
branch
from
e4f2fad to
e2c0c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix for a very slight breaking API change in requests-cache.