Revert urllib3 back to v1 #4806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest v1 release. See #4715. Hopefully this stops the Sentry issue described there from appearing again. This is a short-to-medium term sticking plaster as at some point we'll have to switch to v2.
|
To save a reader tracking back through previous PRs and issues, the context here is that we currently get "remote end closed connection" errors with the OpenTelemetry package, when exporting spans. These apparently didn't happen previously with urllib v1 (#3956); since then, Dependabot managed to get us to update to v2, despite an attempt at pinning the urllib package version. While still on urllib v2, we tried updating the OpenTelemetry packages in #4804, and the problem persists. So this PR will see if reverting to urllib v1 will stop the errors. |
Jongmassey
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest v1 release.
See #4715. Hopefully this stops the Sentry issue described there from appearing again. This is a short-to-medium term sticking plaster as at some point we'll have to switch to v2.