Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autocomplete for first_for_patient()/last_for_patient() #2388

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rw251
Copy link
Contributor

@rw251 rw251 commented Jan 30, 2025

This is still a work in progress. We still need to add some sort of way of checking that the things in ./patient_level_table_definitions match 1-2-1 with the EventFrame tables.

  • could be a check in the @table property, but would need some gymnastics to exclude things like tables created in tests
  • maybe better as a test
  • would need to exclude things like tpp.medications which extends from core.medications (rather than EventFrame) and adds a column. This doesn't work with the existing implementation. Could be added in future.
  • maybe the just update-patient-level-table-definitions could be part of the devenv command so it would get called e.g. when tests were run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant