Clean up logical terminology #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inglesp
approved these changes
Nov 29, 2023
This gives us more consistent terminology. We retain the old name as an alias for backwards compatibility.
This gives us more consistent terminology. We retain the old name as an alias for backwards compatibility.
evansd
force-pushed
the
evansd/logical-terminology
branch
from
9802a79 to
9a5d811
Compare
Deploying with
|
| Latest commit: |
9a5d811
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://516f07ac.databuilder.pages.dev |
| Branch Preview URL: | https://evansd-logical-terminology.databuilder.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes to our logical functions:
case(..., default=...)withcase(..., otherwise=...)if_null_then()withwhen_null_then()In both cases this gives us better consistency of terminology. The old functions/arguments are retained as aliases for now so there are no backwards compatibility concerns.
We plan to remove the aliases when we release
v1.Closes #1439
Closes #1621