fix: Fix appointments.status mapping
#1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The different status values are in two groups. The first group contains a progression: Arrived -> In Progress -> Finished. The second group contains the remaining status values. For brevity, they aren't assembled into a progression: Waiting, Visit, Patient Walked Out. The status values are those that Cohort Extractor's `patients.with_gp_consultations` function considers to be valid. Users may filter by these status values to replicate this function, which is why we test them here.
The mapping itself is a `CASE` statement in `TPPBackend.appointments`. Confusingly, the keys in the mapping have gaps: 7 and 13 are missing. We can confirm this by querying the `DataDictionary` table and also by looking at the equivalent mapping in Cohort Extractor (`cohortextractor.tpp_backend.AppointmentStatus`).
Deploying with
|
| Latest commit: |
071b90a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55e2a384.databuilder.pages.dev |
| Branch Preview URL: | https://iaindillingham-fix-appointme-srr9.databuilder.pages.dev |
inglesp
approved these changes
Nov 28, 2023
iaindillingham
deleted the
iaindillingham/fix-appointments-status-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping itself is a
CASEstatement inTPPBackend.appointments. Confusingly, the keys in the mapping have gaps: 7 and 13 are missing. We can confirm this by querying theDataDictionarytable and also by looking at the equivalent mapping in Cohort Extractor (cohortextractor.tpp_backend.AppointmentStatus).