File downloading #148
Merged
File downloading #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shown for output-checkers only, and not for their own requests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bloodearnest
approved these changes
Mar 6, 2024
We said we'd allow any files to be downloaded, given that CSV is the most high-risk anyway, and we're limiting it to output-checkers and release request files only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the existing
contents_url, and the default for the download filename (i.e. uses the existing filename). I don't think there's a need to include group names or paths in the downloaded filename.As discussed, only output-checkers can download release request files, and only for requests that they did not author. We don't restrict the types of files that can be downloaded by output-checkers. No workspace files can be downloaded by anyone.
Fixes #126