API refactor: make ReleaseRequest responsible for abspath #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bloodearnest
commented
Mar 5, 2024
bloodearnest
commented
- Use container abspath in _absolute_path
- Handle request abspath in the api layer.
I accidentally duplicated the logic here
bloodearnest
force-pushed
the
api-cleanups
branch
from
524978e to
1df0c41
Compare
evansd
approved these changes
Mar 5, 2024
A path locating a file in a request has the form `group/path/file`, and the file on disk is just `root/path/file`. Previously, this discrepency was handled in file_browser_api layer, at tree construction time. Building on the previous commit, we move this to be a responsibility of the ReleaseRequest container. Its abspath() now expected the full path including group, validates the group part, and returns the abspath on disk. Also, in the copy logic, we no longer use abspath to get the destination path, instead using `root / path`. This means abspath can now verify the path exists, like workspaces abspath does. This is much cleaner, and removes some logic and attributes from PathItem.
bloodearnest
force-pushed
the
api-cleanups
branch
from
1df0c41 to
9ba2532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.